Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Support helm 3.x #401

Closed
krichter722 opened this issue Dec 8, 2019 · 14 comments
Closed

Support helm 3.x #401

krichter722 opened this issue Dec 8, 2019 · 14 comments
Assignees
@jmlrt
Labels
project:helm3

Comments

@krichter722
Copy link
Contributor

krichter722 commented Dec 8, 2019 •
edited by jmlrt
Loading

Describe the feature:
I'd be nice if helm 3.x would be supported. It's released and unfortunately a lot of issues with helm 2.x are only solved in 3.x.

Describe a specific use case for the feature:
Installation with helm 3.x because I use it/have to use it for other chart installations.

Currently the following charts are experiencing issues with helm 3.x:
@krichter722 krichter722 mentioned this issue Dec 8, 2019
Closed
4 tasks
@gadelkareem
Copy link

I managed to install the chart with Helm 3 by extracting the template helm template then adding the template to a new empty Helm 3 compatible chart. All working fine so far, only Kibana is misbehaving.

@drenze
Copy link

drenze commented Dec 18, 2019

With the exception of needing to define a service in logstash, everything has installed fine for me as-is under Helm 3. However, it should be noted that I am installing the charts as subcharts of a Helm 3 chart, which may or may not make a difference.

@gadelkareem
Copy link

Kibana worked after reinstalling the kibana helm chart the same way with helm 3. So it is just a matter of adding the Chart.yaml file

@pbecotte
Copy link
Contributor

pbecotte commented Jan 1, 2020

I've been using helm 3 since the first beta (including these), and haven't yet had to modify a chart to get it to work (fingers crossed)

@desaintmartin
Copy link
Contributor

FYI: #437 for helm 3 migration.

@lucaskjaero lucaskjaero mentioned this issue Mar 13, 2020
Merged
@krichter722
Copy link
Contributor Author

Work is also happening in #516.

@Crazybus Crazybus mentioned this issue Apr 16, 2020
Merged
4 tasks
@botelastic
Copy link

botelastic bot commented Jun 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@jmlrt jmlrt mentioned this issue Jun 26, 2020
Merged
@jmlrt
Copy link
Member

jmlrt commented Sep 2, 2020

FYI, Helm 3 support has been added in beta with 7.9.0 and 6.8.12 releases => #759

@jmlrt jmlrt mentioned this issue Nov 10, 2020
Merged
@jmlrt
Copy link
Member

jmlrt commented Nov 10, 2020

Updating rbac.authorization.k8s.io API is required to make helm lint --strict work with Helm 3 => #890

@jmlrt jmlrt self-assigned this Nov 10, 2020
@jmlrt jmlrt mentioned this issue Nov 12, 2020
Merged
4 tasks
@jamshid
Copy link

jamshid commented Nov 14, 2020

Hopefully coming, helm 2 is EOL. https://helm.sh/blog/helm-2-becomes-unsupported/

@jmlrt jmlrt pinned this issue Nov 16, 2020
@jmlrt
Copy link
Member

jmlrt commented Nov 16, 2020 •
edited
Loading

Current status of Helm 3 support work:

The remaining tasks are:

  • upgrade tests and document breaking changes if needed
  • add Helm 3 to GA support in 7.10.0 release

@dominik-bln
Copy link

dominik-bln commented Nov 18, 2020 •
edited
Loading

Helm 3 made changes to how tests are cleaned up. Before it was possible to run helm test --cleanup .., now the manifests seem to need an annotation "helm.sh/hook-delete-policy": hook-succeeded to be properly deleted (as briefly mentioned at the bottom of the new docs).

When running the chart tests with Helm 3 we are seeing the tests pile up:

Screenshot 2020-11-18 at 10 28 04

Would it be possible to add that annotation? Should I open a new issue or PR for this change?

@jmlrt jmlrt mentioned this issue Nov 18, 2020
Merged
jmlrt added a commit to jmlrt/helm-charts that referenced this issue Nov 18, 2020
@jmlrt
[elasticsearch] update test hook annotation
bda54ff 
This commit update Elasticsearch chart test hook annotations for Helm 3
and add a new annotation to automate test pod deletion when test is
successful.

Related to elastic#401 (comment)
@jmlrt
Copy link
Member

jmlrt commented Nov 18, 2020

@dominik-bln, Thanks for the tips, I thought that test pods where cleaned automatically with Helm 3 but it seems not. I created #911 to fix it.

jmlrt added a commit that referenced this issue Nov 18, 2020
@jmlrt
[elasticsearch] update test hook annotations (#911)
aeb3808 
This commit update Elasticsearch chart test hook annotations for Helm 3
and add a new annotation to automate test pod deletion when test is
successful.

Related to #401 (comment)
jmlrt added a commit that referenced this issue Nov 18, 2020
@jmlrt
[elasticsearch] update test hook annotations (#911)
bcc1208 
This commit update Elasticsearch chart test hook annotations for Helm 3
and add a new annotation to automate test pod deletion when test is
successful.

Related to #401 (comment)
jmlrt added a commit that referenced this issue Nov 18, 2020
@jmlrt
[elasticsearch] update test hook annotations (#911)
e5c7cff 
This commit update Elasticsearch chart test hook annotations for Helm 3
and add a new annotation to automate test pod deletion when test is
successful.

Related to #401 (comment)
@jmlrt
Copy link
Member

jmlrt commented Nov 20, 2020

Helm 3 work is done and will be part of 7.10.0 release soon.

@jmlrt jmlrt closed this as completed Nov 20, 2020
@jmlrt jmlrt unpinned this issue Nov 24, 2020
galina-tochilkin pushed a commit to mtp-devops/3d-party-helm that referenced this issue Dec 20, 2022
@jmlrt
[elasticsearch] update test hook annotations (#911)
93c0980 
This commit update Elasticsearch chart test hook annotations for Helm 3
and add a new annotation to automate test pod deletion when test is
successful.

Related to elastic/helm-charts#401 (comment)
galina-tochilkin pushed a commit to mtp-devops/3d-party-helm that referenced this issue Dec 20, 2022
@jmlrt
[elasticsearch] update test hook annotations (#911)
2aa5afd 
This commit update Elasticsearch chart test hook annotations for Helm 3
and add a new annotation to automate test pod deletion when test is
successful.

Related to elastic/helm-charts#401 (comment)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmlrt jmlrt

Labels
project:helm3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@jamshid @desaintmartin @dominik-bln @gadelkareem @drenze @pbecotte @krichter722 @jmlrt