This repository has been archived by the owner on May 16, 2023. It is now read-only.
Metricbeat improvements #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[metricbeat] fix test_cluster_role_rules
mdelapenya
previously approved these changes
Apr 8, 2020
There was a problem hiding this comment.
LGTM, I'd like @ChrsMark to also review it, as his team is the stakeholder of the Helm chart reference
ChrsMark
reviewed
Apr 9, 2020
| - apiGroups: ["apps"] | ||
| resources: | ||
| - statefulsets | ||
| - deployments |
There was a problem hiding this comment.
We also need replicasets here. There was an issue with this: elastic/beats#15741
This mount don't seem to be used by metricbeat as we don't use `add_docker_metadata` processor.
[metricbeat] fix goss tests
ChrsMark
approved these changes
Apr 9, 2020
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in_clusterconfig fromadd_kubernetes_metadataclusterRoleRuleswith recommended values/var/lib/docker/containermountFixes #559
README.md updated with any new values or changes${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml