Merge pull request #6 from mbondyra/pr/92616

Alternative solution
elastic · Feb 24, 2021 · 1c6120c · 1c6120c
2 parents 97c41c2 + 6b90838
commit 1c6120c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 18 deletions.
diff --git a/x-pack/plugins/lens/public/drag_drop/__snapshots__/drag_drop.test.tsx.snap b/x-pack/plugins/lens/public/drag_drop/__snapshots__/drag_drop.test.tsx.snap
diff --git a/x-pack/plugins/lens/public/drag_drop/drag_drop.scss b/x-pack/plugins/lens/public/drag_drop/drag_drop.scss
@@ -81,12 +81,6 @@
   }
 }
 
-.lnsDragDrop__container {
-  overflow: visible !important; // sass-lint:disable-line no-important
-  width: 100%;
-  height: 100%;
-}
-
 .lnsDragDrop__reorderableDrop {
   position: absolute;
   width: 100%;

diff --git a/x-pack/plugins/lens/public/drag_drop/drag_drop.tsx b/x-pack/plugins/lens/public/drag_drop/drag_drop.tsx
@@ -456,7 +456,7 @@ const DropInner = memo(function DropInner(props: DropInnerProps) {
     isActiveDropTarget && dropType !== 'reorder' && dragging?.ghost ? dragging.ghost : undefined;
 
   return (
-    <div className="lnsDragDrop__container">
+    <>
       {React.cloneElement(children, {
         'data-test-subj': dataTestSubj || 'lnsDragDrop',
         className: classNames(children.props.className, classes, className),
@@ -471,7 +471,7 @@ const DropInner = memo(function DropInner(props: DropInnerProps) {
             style: ghost.style,
           })
         : null}
-    </div>
+    </>
   );
 });
 

diff --git a/...ens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.scss b/...ens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.scss
@@ -11,14 +11,14 @@
   min-height: $euiSizeXXL * 10;
   overflow: visible;
   border: none;
+  height: 100%;
 
   .lnsWorkspacePanelWrapper__pageContentBody {
     @include euiScrollBar;
     flex-grow: 1;
     display: flex;
     align-items: stretch;
     justify-content: stretch;
-    position: absolute;
 
     > * {
       flex: 1 1 100%;