Update role mappings create/update/delete success messages

- to use a toast instead of a callout - update copy to match EUI guidelines
elastic · Jun 26, 2021 · 2dc4826 · 2dc4826
1 parent 8f5957c
commit 2dc4826
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/...ns/enterprise_search/public/applications/app_search/components/role_mappings/constants.ts b/...ns/enterprise_search/public/applications/app_search/components/role_mappings/constants.ts
@@ -12,21 +12,21 @@ import { AdvanceRoleType } from '../../types';
 export const ROLE_MAPPING_DELETED_MESSAGE = i18n.translate(
   'xpack.enterpriseSearch.appSearch.roleMappingDeletedMessage',
   {
-    defaultMessage: 'Successfully deleted role mapping',
+    defaultMessage: 'Your role mapping was deleted',
   }
 );
 
 export const ROLE_MAPPING_CREATED_MESSAGE = i18n.translate(
   'xpack.enterpriseSearch.appSearch.roleMappingCreatedMessage',
   {
-    defaultMessage: 'Role mapping successfully created.',
+    defaultMessage: 'Your role mapping was created',
   }
 );
 
 export const ROLE_MAPPING_UPDATED_MESSAGE = i18n.translate(
   'xpack.enterpriseSearch.appSearch.roleMappingUpdatedMessage',
   {
-    defaultMessage: 'Role mapping successfully updated.',
+    defaultMessage: 'Your role mapping was updated',
   }
 );
 

diff --git a/...earch/public/applications/app_search/components/role_mappings/role_mappings_logic.test.ts b/...earch/public/applications/app_search/components/role_mappings/role_mappings_logic.test.ts
@@ -29,7 +29,7 @@ const emptyUser = { username: '', email: '' };
 
 describe('RoleMappingsLogic', () => {
   const { http } = mockHttpValues;
-  const { clearFlashMessages, flashAPIErrors, setSuccessMessage } = mockFlashMessageHelpers;
+  const { clearFlashMessages, flashAPIErrors, flashSuccessToast } = mockFlashMessageHelpers;
   const { mount } = new LogicMounter(RoleMappingsLogic);
   const DEFAULT_VALUES = {
     attributes: [],
@@ -519,7 +519,7 @@ describe('RoleMappingsLogic', () => {
         await nextTick();
 
         expect(initializeRoleMappingsSpy).toHaveBeenCalled();
-        expect(setSuccessMessage).toHaveBeenCalled();
+        expect(flashSuccessToast).toHaveBeenCalled();
       });
 
       it('sends array when "accessAllEngines" is false', () => {
@@ -670,7 +670,7 @@ describe('RoleMappingsLogic', () => {
         await nextTick();
 
         expect(initializeRoleMappingsSpy).toHaveBeenCalled();
-        expect(setSuccessMessage).toHaveBeenCalled();
+        expect(flashSuccessToast).toHaveBeenCalled();
       });
 
       it('handles error', async () => {

diff --git a/...ise_search/public/applications/app_search/components/role_mappings/role_mappings_logic.ts b/...ise_search/public/applications/app_search/components/role_mappings/role_mappings_logic.ts
@@ -10,7 +10,7 @@ import { kea, MakeLogicType } from 'kea';
 import {
   clearFlashMessages,
   flashAPIErrors,
-  setSuccessMessage,
+  flashSuccessToast,
 } from '../../../shared/flash_messages';
 import { HttpLogic } from '../../../shared/http';
 import {
@@ -396,7 +396,7 @@ export const RoleMappingsLogic = kea<MakeLogicType<RoleMappingsValues, RoleMappi
       try {
         await http.delete(route);
         actions.initializeRoleMappings();
-        setSuccessMessage(ROLE_MAPPING_DELETED_MESSAGE);
+        flashSuccessToast(ROLE_MAPPING_DELETED_MESSAGE);
       } catch (e) {
         flashAPIErrors(e);
       }
@@ -435,7 +435,7 @@ export const RoleMappingsLogic = kea<MakeLogicType<RoleMappingsValues, RoleMappi
       try {
         await request;
         actions.initializeRoleMappings();
-        setSuccessMessage(SUCCESS_MESSAGE);
+        flashSuccessToast(SUCCESS_MESSAGE);
       } catch (e) {
         actions.setRoleMappingErrors(e?.body?.attributes?.errors);
       }