lens suffix formatter fix

elastic · Jul 29, 2021 · 39c16f7 · 39c16f7
1 parent 41f25a7
commit 39c16f7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/x-pack/plugins/lens/common/suffix_formatter/index.ts b/x-pack/plugins/lens/common/suffix_formatter/index.ts
@@ -31,6 +31,7 @@ export const unitSuffixesLong: Record<TimeScaleUnit, string> = {
 export function getSuffixFormatter(formatFactory: FormatFactory): FieldFormatInstanceType {
   return class SuffixFormatter extends FieldFormat {
     static id = 'suffix';
+    static hidden = true; // Don't want this format to appear in index pattern editor
     static title = i18n.translate('xpack.lens.fieldFormats.suffix.title', {
       defaultMessage: 'Suffix',
     });

diff --git a/x-pack/plugins/lens/common/suffix_formatter/suffix_formatter.test.ts b/x-pack/plugins/lens/common/suffix_formatter/suffix_formatter.test.ts
@@ -42,4 +42,11 @@ describe('suffix formatter', () => {
 
     expect(result).toEqual('');
   });
+
+  it('should be a hidden formatter', () => {
+    const convertMock = jest.fn((x) => '');
+    const formatFactory = jest.fn(() => ({ convert: convertMock }));
+    const SuffixFormatter = getSuffixFormatter((formatFactory as unknown) as FormatFactory);
+    expect(SuffixFormatter.hidden).toBe(true);
+  });
 });