Skip to content

Commit

Permalink
[Security Solution] Fix and unskip Policy details tests (#122099)
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinlog committed Jan 3, 2022
1 parent 5817a51 commit 649853d
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/92567
describe.skip('and the save button is clicked', () => {
describe('and the save button is clicked', () => {
let policyInfo: PolicyTestResourceInfo;

beforeEach(async () => {
Expand Down Expand Up @@ -367,7 +366,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await pageObjects.policy.confirmAndSave();

await testSubjects.existOrFail('policyDetailsSuccessMessage');
await pageObjects.common.closeToast();
await testSubjects.waitForHidden('toastCloseButton');
await pageObjects.endpoint.navigateToEndpointList();
await pageObjects.policy.navigateToPolicyDetails(policyInfo.packagePolicy.id);

Expand Down Expand Up @@ -395,6 +394,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await pageObjects.policy.confirmAndSave();

await testSubjects.existOrFail('policyDetailsSuccessMessage');
await testSubjects.waitForHidden('toastCloseButton');

const agentFullPolicy = await policyTestResources.getFullAgentPolicy(
policyInfo.agentPolicy.id
Expand Down Expand Up @@ -442,6 +442,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await pageObjects.policy.confirmAndSave();

await testSubjects.existOrFail('policyDetailsSuccessMessage');
await testSubjects.waitForHidden('toastCloseButton');

const agentFullPolicy = await policyTestResources.getFullAgentPolicy(
policyInfo.agentPolicy.id
Expand Down Expand Up @@ -476,7 +477,6 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await advancedPolicyField.clearValueWithKeyboard();

// Make sure the toast button closes so the save button on the sticky footer is visible
await (await testSubjects.find('toastCloseButton')).click();
await testSubjects.waitForHidden('toastCloseButton');
await pageObjects.policy.confirmAndSave();

Expand All @@ -490,7 +490,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
getExpectedAgentPolicyEndpointInput({
id: policyInfo.packagePolicy.id,
name: policyInfo.packagePolicy.name,
revision: 3,
revision: agentFullPolicyUpdated.inputs[0].revision,
meta: {
package: {
version: policyInfo.packageInfo.version,
Expand Down

0 comments on commit 649853d

Please sign in to comment.