Improve tests

x-pack/plugins/security_solution/public/cases/components/use_all_cases_modal/all_cases_modal.test.tsx

@@ -3,17 +3,24 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
+
+/* eslint-disable react/display-name */
 import { mount } from 'enzyme';
 import React from 'react';
 import '../../../common/mock/match_media';
 import { AllCasesModal } from './all_cases_modal';
 import { TestProviders } from '../../../common/mock';
 
 jest.mock('../all_cases', () => {
-  const AllCases = () => {
-    return <></>;
+  return {
+    AllCases: ({ onRowClick }: { onRowClick: ({ id }: { id: string }) => void }) => {
+      return (
+        <button type="button" onClick={() => onRowClick({ id: 'case-id' })}>
+          {'case-row'}
+        </button>
+      );
+    },
   };
-  return { AllCases };
 });
 
 jest.mock('../../../common/lib/kibana', () => {
@@ -82,4 +89,15 @@ describe('AllCasesModal', () => {
       isModal: true,
     });
   });
+
+  it('onRowClick called when row is clicked', () => {
+    const wrapper = mount(
+      <TestProviders>
+        <AllCasesModal {...defaultProps} />
+      </TestProviders>
+    );
+
+    wrapper.find(`[data-test-subj='all-cases-row']`).first().simulate('click');
+    expect(onRowClick).toHaveBeenCalledWith({ id: 'case-id' });
+  });
 });

x-pack/plugins/security_solution/public/cases/components/use_all_cases_modal/index.test.tsx

@@ -5,7 +5,6 @@
  */
 
 /* eslint-disable react/display-name */
-
 import React from 'react';
 import { renderHook, act } from '@testing-library/react-hooks';
 import { render, screen } from '@testing-library/react';
@@ -29,9 +28,9 @@ jest.mock('react-redux', () => {
 jest.mock('../../../common/lib/kibana');
 jest.mock('../all_cases', () => {
   return {
-    AllCases: ({ onRowClick }: { onRowClick: (id: string, title: string) => void }) => {
+    AllCases: ({ onRowClick }: { onRowClick: ({ id }: { id: string }) => void }) => {
       return (
-        <button type="button" onClick={() => onRowClick('case-id', 'case title')}>
+        <button type="button" onClick={() => onRowClick({ id: 'case-id' })}>
           {'case-row'}
         </button>
       );
@@ -130,6 +129,6 @@ describe('useAllCasesModal', () => {
     });
 
     expect(result.current.isModalOpen).toBe(false);
-    expect(onRowClick).toHaveBeenCalledWith('case-id', 'case title');
+    expect(onRowClick).toHaveBeenCalledWith({ id: 'case-id' });
   });
 });

x-pack/plugins/security_solution/public/timelines/components/timeline/body/events/event_column_view.test.tsx

@@ -51,7 +51,7 @@ describe('EventColumnView', () => {
     selectedEventIds: {},
     showCheckboxes: false,
     showNotes: false,
-    timelineId: 'timeline-1',
+    timelineId: 'timeline-test',
     toggleShowNotes: jest.fn(),
     updateNote: jest.fn(),
     isEventPinned: false,