signalsCreatedCount is initialized to a number and should never be null

elastic · Jul 14, 2020 · 890ef86 · 890ef86
1 parent 715837b
commit 890ef86
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/...plugins/security_solution/server/lib/detection_engine/signals/search_after_bulk_create.ts b/...plugins/security_solution/server/lib/detection_engine/signals/search_after_bulk_create.ts
@@ -186,10 +186,7 @@ export const searchAfterAndBulkCreate = async ({
         }
 
         // make sure we are not going to create more signals than maxSignals allows
-        if (
-          signalsCreatedCount != null &&
-          signalsCreatedCount + filteredEvents.hits.hits.length > tuple.maxSignals
-        ) {
+        if (signalsCreatedCount + filteredEvents.hits.hits.length > tuple.maxSignals) {
           filteredEvents.hits.hits = filteredEvents.hits.hits.slice(
             0,
             tuple.maxSignals - signalsCreatedCount