use semver to compare versions (#72107)

elastic · Jul 16, 2020 · a994f57 · a994f57
1 parent acf0617
commit a994f57
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/x-pack/plugins/ingest_manager/server/services/epm/packages/install.ts b/x-pack/plugins/ingest_manager/server/services/epm/packages/install.ts
@@ -6,6 +6,7 @@
 
 import { SavedObjectsClientContract } from 'src/core/server';
 import Boom from 'boom';
+import semver from 'semver';
 import { PACKAGES_SAVED_OBJECT_TYPE } from '../../../constants';
 import {
   AssetReference,
@@ -95,8 +96,7 @@ export async function installPackage(options: {
   // TODO: calls to getInstallationObject, Registry.fetchInfo, and Registry.fetchFindLatestPackge
   // and be replaced by getPackageInfo after adjusting for it to not group/use archive assets
   const latestPackage = await Registry.fetchFindLatestPackage(pkgName);
-
-  if (pkgVersion < latestPackage.version)
+  if (semver.lt(pkgVersion, latestPackage.version))
     throw Boom.badRequest('Cannot install or update to an out-of-date package');
 
   const paths = await Registry.getArchiveInfo(pkgName, pkgVersion);