Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use neutral naming for actions URL whitelist #71630

Closed
mikecote opened this issue Jul 14, 2020 · 3 comments · Fixed by #75099
Closed

Use neutral naming for actions URL whitelist #71630

mikecote opened this issue Jul 14, 2020 · 3 comments · Fixed by #75099
Assignees
@YulNaumenko
Labels
Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

Part of #71398.

Move away from using whitelist terminology to a more inclusive allow list approach.

Some areas to consider include:

  • whitelist in actions_config.test.ts tests and whitelistError in actions plugin
  • xpack.actions.urlWhitelistConfigurationError translation
  • in docs/user/alerting/index.asciidoc
@mikecote mikecote added Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jul 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@streamich streamich mentioned this issue Jul 14, 2020
Closed
21 tasks
@mikecote
Copy link
Contributor Author

Should probably notify cloud of these changes

@mikecote
Copy link
Contributor Author

Waiting until a general consensus is reached on naming: #71398.

@mikecote mikecote changed the title Use inclusive language for actions URL whitelist Use neutral naming for actions URL whitelist Jul 15, 2020
@YulNaumenko YulNaumenko self-assigned this Aug 12, 2020
@YulNaumenko YulNaumenko mentioned this issue Aug 14, 2020
Merged
@YulNaumenko YulNaumenko mentioned this issue Sep 3, 2020
Merged
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Whitelist to AllowList in Actions and Alerting YulNaumenko/kibana
4 participants
@kobelb @mikecote @elasticmachine @YulNaumenko