Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neutral-naming in Kibana #71398

Closed
19 of 21 tasks
streamich opened this issue Jul 12, 2020 · 13 comments
Closed
19 of 21 tasks

Neutral-naming in Kibana #71398

streamich opened this issue Jul 12, 2020 · 13 comments
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Operations Team label for Operations Team Team:Platform Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@streamich
Copy link
Contributor

streamich commented Jul 12, 2020 •
edited by paulb-elastic
Loading

Elastic has decided to move away from white/black-list terms to more inclusive allow/deny-list, this issue tracks places in Kibana we need to refactor for allow/deny-list:

Allow list:

Deny list:
@streamich streamich added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:AppArch Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:Operations Team label for Operations Team Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:SIEM Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jul 12, 2020
@streamich streamich mentioned this issue Jul 12, 2020
Merged
@flash1293 flash1293 mentioned this issue Jul 13, 2020
Merged
@jsanz jsanz mentioned this issue Jul 13, 2020
Merged
@jloleysens jloleysens mentioned this issue Jul 13, 2020
Merged
1 task
@clintandrewhall clintandrewhall mentioned this issue Jul 13, 2020
Merged
@andrewvc andrewvc mentioned this issue Jul 14, 2020
Closed
@pgayvallet pgayvallet mentioned this issue Jul 14, 2020
Merged
@pgayvallet
Copy link
Contributor

pgayvallet commented Jul 14, 2020 •
edited
Loading

I got a couple questions:

  • To which version(s) should this be backported?

  • Do we have any consensus on new terminology / naming, for consistency?

In names (more specifically user facing config properties)

elasticsearch.requestHeadersWhitelist -> elasticsearch.requestHeadersAllowlist or elasticsearch.allowedRequestHeaders ?

when used as a verb:

This is used to whitelist the key -> This is used to allow the key or This is used to allowlist the key

@mshustov
Copy link
Contributor

I'd go with elasticsearch.allowedRequestHeaders, which sounds more natural and simplifies reading.

This was referenced Jul 14, 2020
Closed
Closed
@mikecote mikecote mentioned this issue Jul 14, 2020
Closed
@clintandrewhall
Copy link
Contributor

clintandrewhall commented Jul 14, 2020 •
edited
Loading

If it helps anyone else, I think a lot of these don't need to be "replace white and black with allow and disallow". For example, in #71522, I noticed blacklist was easily replaced with invalid. YMMV.

@jbudz
Copy link
Member

jbudz commented Jul 14, 2020

I hate to combine two issues, but changing kibana.yml settings is a big enough hassle that it may be worth doing the snake case and stack consistency check as part of this.

@lcawl
Copy link
Contributor

lcawl commented Jul 14, 2020

FYI There's some work going on to come up with a project plan to get consistency on this refactoring as much as possible across the stack. Don't have a link yet, but coming soon.

@pgayvallet
Copy link
Contributor

@jbudz I guess I should put #71625 and #71610. on standby then?

@paulb-elastic paulb-elastic removed Team:AppServices Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Nov 24, 2020
@paulb-elastic
Copy link
Contributor

Zube action closed this, so re-opening

@paulb-elastic paulb-elastic reopened this Nov 24, 2020
@legrego legrego mentioned this issue Dec 1, 2020
Closed
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@cjcenizal cjcenizal mentioned this issue Dec 4, 2020
Merged
7 tasks
jbudz added a commit to jbudz/kibana that referenced this issue Mar 5, 2021
@jbudz
[license checker] Neutral naming
3665f38 
This changes text in our license checker to support our neutral naming
efforts in elastic#71398.

LICENSE_WHITELIST -> LICENSE_ALLOWED
DEV_ONLY_LICENSE_WHITELIST -> DEV_ONLY_LICENSE_ALLOWED
@jbudz jbudz mentioned this issue Mar 5, 2021
Merged
jbudz added a commit that referenced this issue Mar 5, 2021
@jbudz
[license checker] Neutral naming (#93783)
9019946 
This changes text in our license checker to support our neutral naming
efforts in #71398.

LICENSE_WHITELIST -> LICENSE_ALLOWED
DEV_ONLY_LICENSE_WHITELIST -> DEV_ONLY_LICENSE_ALLOWED
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 5, 2021
@jbudz @kibanamachine
[license checker] Neutral naming (elastic#93783)
980c345 
This changes text in our license checker to support our neutral naming
efforts in elastic#71398.

LICENSE_WHITELIST -> LICENSE_ALLOWED
DEV_ONLY_LICENSE_WHITELIST -> DEV_ONLY_LICENSE_ALLOWED
kibanamachine added a commit that referenced this issue Mar 5, 2021
@kibanamachine @jbudz
[license checker] Neutral naming (#93783) (#93824)
eedea24 
This changes text in our license checker to support our neutral naming
efforts in #71398.

LICENSE_WHITELIST -> LICENSE_ALLOWED
DEV_ONLY_LICENSE_WHITELIST -> DEV_ONLY_LICENSE_ALLOWED

Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
@streamich
Copy link
Contributor Author

Thank you everyone for doing the changes. Closing this as there are only a couple of references left in Core team but they are aware of them and those are public APIs.

@mshustov mshustov mentioned this issue Sep 29, 2021
Merged
1 task
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Operations Team label for Operations Team Team:Platform Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests