Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inclusive language - elasticsearch config #71610

Closed
wants to merge 4 commits into from
Closed

inclusive language - elasticsearch config #71610

wants to merge 4 commits into from

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jul 14, 2020 •
edited
Loading

Summary

Part of #71398

  • rename elasticsearch.requestHeadersWhitelist config property to elasticsearch.allowedRequestHeaders
  • adapt console plugin code to reflect the changes.

Checklist

@pgayvallet pgayvallet changed the title inclusive language - elasticsearch confif inclusive language - elasticsearch config Jul 14, 2020
@streamich streamich mentioned this pull request Jul 14, 2020
Closed
21 tasks
@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 14, 2020
pgayvallet
pgayvallet commented Jul 14, 2020
View reviewed changes
src/core/server/elasticsearch/elasticsearch_config.test.ts
Comment on lines -318 to +332
"Setting [${CONFIG_PATH}.username] to \\"elastic\\" is deprecated. You should use the \\"kibana_system\\" user instead.",
"Setting [elasticsearch.username] to \\"elastic\\" is deprecated. You should use the \\"kibana_system\\" user instead.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the snapshots removed the var, however it felt unnecessary here, so I did not revert the change.

@pgayvallet pgayvallet added release_note:deprecation v7.10.0 and removed release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 14, 2020
@pgayvallet pgayvallet marked this pull request as ready for review July 14, 2020 14:12
@pgayvallet pgayvallet requested review from a team as code owners July 14, 2020 14:12
@pgayvallet pgayvallet requested a review from a team July 14, 2020 14:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

igoristic
igoristic approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack Monitoring looks good 👍

@pgayvallet
Copy link
Contributor Author

Closing - see #71398 (comment)

@pgayvallet pgayvallet closed this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees
No one assigned
Labels
release_note:deprecation Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgayvallet @elasticmachine @kibanamachine @igoristic