Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Ensure inclusive language #71416

Merged
merged 3 commits into from
Jul 14, 2020

Conversation

flash1293
Copy link
Contributor

Part of #71398

Renames blacklist to blocklist in code. The interface already used the "blocklist" term, this is just making the code consistent. I'm aware we use "deny-list" in other places, but as we went with "blocklist" already, IMHO it makes sense to just stick with it.

This also adds a migration to rename the similar named key in the saved object.

As a side effect this also renames another occurrence in the timelion docs.

@flash1293 flash1293 added Feature:Timelion Timelion app and visualization Feature:Graph Graph application feature v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Jul 13, 2020
@streamich streamich mentioned this pull request Jul 13, 2020
21 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review July 13, 2020 14:38
@flash1293 flash1293 requested a review from a team July 13, 2020 14:38
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jul 13, 2020
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thx for making Graph more inclusive 👍 , tested locally in Chrome, Firefox, blocking nodes works. Didn't test the migration, but looks good to me code wise.

@kertal
Copy link
Member

kertal commented Jul 14, 2020

Think I've also tested the upgrade, because looking at the ecommerce the demo data, the block list contains data:
Bildschirmfoto 2020-07-14 um 16 58 14

@flash1293
Copy link
Contributor Author

flash1293 commented Jul 14, 2020

Thanks for testing @kertal I updated the sample data as well, so if you installed while on this PR, it wouldn't test the migration, but if you installed it earlier than this would indeed validate the migration worked.

@kertal
Copy link
Member

kertal commented Jul 14, 2020

Thanks for testing @kertal I updated the sample data as well, so if you installed while on this PR, it wouldn't test the migration, but if you installed it earlier than this would indeed validate the migration worked.

was installed before, so it was migrated

@flash1293 flash1293 merged commit 4e97bb1 into elastic:master Jul 14, 2020
flash1293 added a commit to flash1293/kibana that referenced this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants