Migrate CCR to new ES JS client. #100131

cjcenizal · 2021-05-14T15:14:37Z

Summary

Partially addresses #73973 and #83910.

Changes

Updated README with new steps to test
Updated plugin server code
Update API integration tests
Update functional tests
Audit for SectionError ([ES UI] Audit plugins using <SectionError/> component #84801)
Add missing test for follower index update route
File issues to report incorrect types https://github.com/elastic/elasticsearch-specification/issues (some might possibly be fixed by Update @elastic/elasticsearch to 8.0.0-canary13 #98266)
- ccr.getAutoFollowPattern
- ccr.stats
- ccr.followInfo
- ccr.followStats

Behavior to test

Actions

Errors

All errors were produced by editing the ES requests inside the API route handlers.

Error checking permissions.

Error creating auto-follow pattern.

Error creating follower index.

Can't load auto-follow pattern (404).

Can't load follower index (404).

cjcenizal · 2021-05-14T23:47:18Z

x-pack/test/api_integration/apis/management/cross_cluster_replication/follower_indices.js

@@ -74,17 +74,17 @@ export default function ({ getService }) {

    describe('get()', () => {
      it('should return a 404 when the follower index does not exist', async () => {
-        const name = getRandomString();


@sebelga I removed this helper in favor of explicit hard-coded values for a couple reasons:

When debugging a test gone wrong (for example, clean up code that deletes these primitives), explicit hard-coded values can provide debugging information

I generally try to simplify systems by removing any code that isn't necessary, and it didn't seem necessary to me to randomize these values

Do I have your blessing to make this change? :)

Agreed on the reasoning. You do have my blessing! 👍 :)

Thank you, Seb!

cjcenizal · 2021-05-15T01:03:18Z

x-pack/plugins/cross_cluster_replication/README.md

-2. Start your "remote" cluster by running `yarn es snapshot --license=trial -E cluster.name=europe -E transport.port=9400` in a separate terminal tab.
-3. Index a document into your remote cluster by running `curl -X PUT http://elastic:changeme@localhost:9201/my-leader-index --data '{"settings":{"number_of_shards":1,"soft_deletes.enabled":true}}' --header "Content-Type: application/json"`.
-Note that these settings are required for testing auto-follow pattern conflicts errors (see below).
+1. Ensure Kibana isn't running so it doesn't load up any data into your cluster. Run `yarn es snapshot --license=trial` to install a fresh snapshot. Wait for ES to finish setting up.


@yuliacech I believe you wrote these originally, but I wasn't able to get the original instructions to work. Can you check this and see if I was just doing it wrong?

Thanks for updating those instructions, @cjcenizal! I can confirm that the previous instructions didn't work for me either, tested your steps and it worked like a charm 👍

cjcenizal · 2021-05-15T01:03:50Z

x-pack/plugins/cross_cluster_replication/public/app/components/section_error.js

@@ -11,21 +11,19 @@ import { EuiCallOut, EuiSpacer } from '@elastic/eui';
 export function SectionError(props) {


I'll migrate this to use our shared SectionError as part of #84801

elasticmachine · 2021-05-15T01:23:43Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cjcenizal · 2021-05-28T22:16:14Z

@elasticmachine merge upstream

yuliacech · 2021-06-01T13:25:23Z

x-pack/plugins/cross_cluster_replication/server/types.ts

@@ -25,24 +24,9 @@ export interface StartDependencies {
 }

 export interface RouteDependencies {
-  router: CcrPluginRouter;
+  router: IRouter<RequestHandlerContext>;


nit: RequestHandlerContext is the default value of the generics in the IRouter interface

Suggested change

router: IRouter<RequestHandlerContext>;

router: IRouter;

yuliacech · 2021-06-01T13:25:36Z

x-pack/plugins/cross_cluster_replication/server/types.ts

@@ -5,13 +5,12 @@
 * 2.0.
 */

-import { IRouter, ILegacyScopedClusterClient, RequestHandlerContext } from 'src/core/server';
+import { IRouter, RequestHandlerContext } from 'src/core/server';


nit: RequestHandlerContext is not needed, see comment below

Suggested change

import { IRouter, RequestHandlerContext } from 'src/core/server';

import { IRouter } from 'src/core/server';

yuliacech

Hi @cjcenizal, thanks a lot for migrating CCR to the new js client.
I tested locally and everything seems to work as before, I haven't noticed any regressions. Code changes LGTM too 👍 Just left a couple of nits in the comments.

kibanamachine · 2021-06-01T16:38:39Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`crossClusterReplication`	293.3KB	293.5KB	+163.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`crossClusterReplication`	6	2	-4

History

💚 Build #128080 succeeded 1eab4f7
💚 Build #126134 succeeded 7439e7b
💔 Build #126037 failed 78d822b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Update SectionError component to render error root causes correctly. * Fix 404 error rendering. * Add test for follower index update API route.

…sens/kibana into reporting/new-png-pdf-report-type * 'reporting/new-png-pdf-report-type' of github.com:jloleysens/kibana: (46 commits) [Security Solution] Add Ransomware canary advanced policy option (elastic#101068) [Exploratory view] Core web vitals (elastic#100320) [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034) [Lens] Use a setter function for the dimension panel (elastic#101123) [Index Patterns] Fix return saved index pattern object (elastic#101051) [CI] For PRs, build TS refs before public api docs check (elastic#100791) [Maps] fix line and polygon label regression (elastic#101085) Migrate CCR to new ES JS client. (elastic#100131) [Canvas] Switch Canvas to use React Router (elastic#100579) [Expressions] Use table column ID instead of name when set (elastic#99724) [DOCS] Updates docs landing page (elastic#100749) [DOCS] Corrects typo in step 3 (elastic#101079) [DOCS] Updates runtime example in Discover (elastic#100926) Migrate kibana.autocomplete config to data plugin (elastic#100586) [Uptime] New width/delay definition for waterfall sidebar item tooltip (elastic#100147) [FTR] Use importExport for saved_object/basic archive (elastic#100244) [Fleet] Better input for multi text input in agent policy builder (elastic#101020) [CI] Buildkite support with Baseline pipeline (elastic#100492) [Reporting/Telemetry] Do not send telemetry if we are in screenshot mode (elastic#100388) Create API keys with metadata (elastic#100682) ...

cjcenizal added chore Feature:CCR and Remote Clusters v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels May 14, 2021

cjcenizal added 2 commits May 14, 2021 15:08

Migrate CCR to new ES JS client.

1a3ee00

Update SectionError component to render error root causes correctly.

e0b22af

cjcenizal force-pushed the ccr/migrate-legacy-es-client branch from 78d822b to e0b22af Compare May 14, 2021 22:33

cjcenizal added 3 commits May 14, 2021 15:49

Fix 404 error rendering.

bf26708

Update API integration tests.

f8714b2

Add test for follower index update API route.

7439e7b

cjcenizal commented May 14, 2021

View reviewed changes

cjcenizal mentioned this pull request May 15, 2021

Stack Management elasticsearch-js client migration #73973

Closed

17 tasks

cjcenizal commented May 15, 2021

View reviewed changes

cjcenizal marked this pull request as ready for review May 15, 2021 01:23

cjcenizal requested a review from a team as a code owner May 15, 2021 01:23

yuliacech reviewed Jun 1, 2021

View reviewed changes

yuliacech approved these changes Jun 1, 2021

View reviewed changes

cjcenizal added 2 commits June 1, 2021 07:55

Merge branch 'master' into ccr/migrate-legacy-es-client

7882b5f

Remove default generic from router type def.

f2f583d

cjcenizal force-pushed the ccr/migrate-legacy-es-client branch from 1eab4f7 to f2f583d Compare June 1, 2021 14:58

cjcenizal merged commit ba4e0d2 into elastic:master Jun 1, 2021

cjcenizal deleted the ccr/migrate-legacy-es-client branch June 1, 2021 23:26

cjcenizal mentioned this pull request Jun 1, 2021

[Meta] Switch to the new Elasticsearch client #83910

Closed

74 tasks

cjcenizal mentioned this pull request Jun 1, 2021

[7.x] Migrate CCR to new ES JS client. (#100131) #101125

Merged

cjcenizal added a commit that referenced this pull request Jun 2, 2021

Migrate CCR to new ES JS client. (#100131) (#101125)

e044137

* Update SectionError component to render error root causes correctly. * Fix 404 error rendering. * Add test for follower index update API route.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate CCR to new ES JS client. #100131

Migrate CCR to new ES JS client. #100131

cjcenizal commented May 14, 2021 •

edited

Loading

cjcenizal May 14, 2021

sebelga May 17, 2021

cjcenizal May 17, 2021

cjcenizal May 15, 2021

yuliacech May 17, 2021

cjcenizal May 15, 2021

elasticmachine commented May 15, 2021

cjcenizal commented May 28, 2021

yuliacech Jun 1, 2021

yuliacech Jun 1, 2021 •

edited

Loading

yuliacech left a comment

kibanamachine commented Jun 1, 2021

References to deprecated APIs

		@@ -11,21 +11,19 @@ import { EuiCallOut, EuiSpacer } from '@elastic/eui';
		export function SectionError(props) {

	import { IRouter, RequestHandlerContext } from 'src/core/server';
	import { IRouter } from 'src/core/server';

Migrate CCR to new ES JS client. #100131

Migrate CCR to new ES JS client. #100131

Conversation

cjcenizal commented May 14, 2021 • edited Loading

Summary

Changes

Behavior to test

Actions

Errors

cjcenizal May 14, 2021

Choose a reason for hiding this comment

sebelga May 17, 2021

Choose a reason for hiding this comment

cjcenizal May 17, 2021

Choose a reason for hiding this comment

cjcenizal May 15, 2021

Choose a reason for hiding this comment

yuliacech May 17, 2021

Choose a reason for hiding this comment

cjcenizal May 15, 2021

Choose a reason for hiding this comment

elasticmachine commented May 15, 2021

cjcenizal commented May 28, 2021

yuliacech Jun 1, 2021

Choose a reason for hiding this comment

yuliacech Jun 1, 2021 • edited Loading

Choose a reason for hiding this comment

yuliacech left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 1, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

References to deprecated APIs

History

cjcenizal commented May 14, 2021 •

edited

Loading

yuliacech Jun 1, 2021 •

edited

Loading