Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [TSVB] Fix more than one empty labels in markdown breaks the values for all other labels (#100432) #100548

Merged
merged 2 commits into from
May 26, 2021

Conversation

Kuznietsov
Copy link
Contributor

Backports the following commits to 7.x:

…or all other labels (elastic#100432)

* Fixed multiple empty labels monitoring with [].

* Fixed regexp group behavior and replaced by ''.replaceAll.

* Changed ''.replaceAll with ''.split(...).join(...)

* Added test for (empty) label case.

* Removed not necessary comment.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Kuznietsov Kuznietsov enabled auto-merge (squash) May 25, 2021 13:11
@stratoula
Copy link
Contributor

Jenkins, test this

@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor

Jenkins, test this

1 similar comment
@stratoula
Copy link
Contributor

Jenkins, test this

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.7MB 1.7MB +16.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Kuznietsov Kuznietsov merged commit efb903e into elastic:7.x May 26, 2021
@Kuznietsov Kuznietsov deleted the backport/7.x/pr-100432 branch May 26, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants