-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC] [TGrid] Migrate the TGrid's rendering to EuiDataGrid
#106199
Merged
andrew-goldstein
merged 8 commits into
elastic:master
from
andrew-goldstein:render-via-eui-data-grid
Jul 21, 2021
Merged
[RAC] [TGrid] Migrate the TGrid's rendering to EuiDataGrid
#106199
andrew-goldstein
merged 8 commits into
elastic:master
from
andrew-goldstein:render-via-eui-data-grid
Jul 21, 2021
Commits on Jul 21, 2021
-
This PR migrates TGrid's rendering to use
EuiDataGrid
, per the scre……enshots below: ![o11y_alerts](https://user-images.githubusercontent.com/4459398/126273572-7e02e3b1-c075-4b1a-9b77-03a6843d6b72.png) ![security_solution_alerts](https://user-images.githubusercontent.com/4459398/126279321-60d8c118-a97f-4c3f-b997-a966f7755d33.png) Related RAC Issue: elastic/security-team#1299 To reduce the size of the `timelines` and `security_solution` plugins, legacy TGrid code and the dependency on `react-beautiful-dnd` will be removed in a follow-up PR. - Related issue: elastic#105941 The legacy code and dependencies will be deleted when the following tasks are completed (in follow-up PRs): - Sorting: Map `redux` sort state to `EuiDataGrid`'s `sorting` prop - Actions: Migrate draggable hover actions to `EuiDataGrid` `cellActions` - related PR: <elastic#105500> - Integrate with the Field Browser for adding / removing columns - related PR: <elastic#105207> - Use `BrowserFields` to display field metadata when hovering over a column - related PR: <elastic#105207> - Migrate Security Solution's actions column config from a single column to multiple columns To desk test this PR, you must enable feature flags in the Observability and Security Solution: - To desk test the `Observability > Alerts` page, add the following settings to `config/kibana.dev.yml`: ``` xpack.observability.unsafe.cases.enabled: true xpack.observability.unsafe.alertingExperience.enabled: true xpack.ruleRegistry.write.enabled: true ``` - To desk test the TGrid in the following Security Solution, edit `x-pack/plugins/security_solution/common/experimental_features.ts` and in the `allowedExperimentalValues` section set: ```typescript tGridEnabled: true, ```
Configuration menu - View commit details
-
Copy full SHA for d3107f5 - Browse repository at this point
Copy the full SHA d3107f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88979a2 - Browse repository at this point
Copy the full SHA 88979a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c589818 - Browse repository at this point
Copy the full SHA c589818View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d66a28 - Browse repository at this point
Copy the full SHA 1d66a28View commit details -
- Integrated with the Field Browser for adding / removing columns
- removed a skipped test that is no longer applicable
Configuration menu - View commit details
-
Copy full SHA for d7d6c00 - Browse repository at this point
Copy the full SHA d7d6c00View commit details -
Configuration menu - View commit details
-
Copy full SHA for a975f47 - Browse repository at this point
Copy the full SHA a975f47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a7f93e - Browse repository at this point
Copy the full SHA 6a7f93eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfde95a - Browse repository at this point
Copy the full SHA bfde95aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.