Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] [TGrid] Migrate the TGrid's rendering to EuiDataGrid #106199

Merged

Commits on Jul 21, 2021

  1. This PR migrates TGrid's rendering to use EuiDataGrid, per the scre…

    …enshots below:
    
    ![o11y_alerts](https://user-images.githubusercontent.com/4459398/126273572-7e02e3b1-c075-4b1a-9b77-03a6843d6b72.png)
    
    ![security_solution_alerts](https://user-images.githubusercontent.com/4459398/126279321-60d8c118-a97f-4c3f-b997-a966f7755d33.png)
    
    Related RAC Issue: elastic/security-team#1299
    
    To reduce the size of the `timelines` and `security_solution` plugins, legacy TGrid code and the dependency on `react-beautiful-dnd` will be removed in a follow-up PR.
    
    - Related issue: elastic#105941
    
    The legacy code and dependencies will be deleted when the following tasks are completed (in follow-up PRs):
    
    - Sorting: Map `redux` sort state to `EuiDataGrid`'s `sorting` prop
    - Actions: Migrate draggable hover actions to `EuiDataGrid` `cellActions`
      - related PR: <elastic#105500>
    - Integrate with the Field Browser for adding / removing columns
      - related PR: <elastic#105207>
    - Use `BrowserFields` to display field metadata when hovering over a column
      - related PR: <elastic#105207>
    - Migrate Security Solution's actions column config from a single column to multiple columns
    
    To desk test this PR, you must enable feature flags in the Observability and Security Solution:
    
    - To desk test the `Observability > Alerts` page, add the following settings to `config/kibana.dev.yml`:
    
    ```
    xpack.observability.unsafe.cases.enabled: true
    xpack.observability.unsafe.alertingExperience.enabled: true
    xpack.ruleRegistry.write.enabled: true
    ```
    
    - To desk test the TGrid in the following Security Solution, edit `x-pack/plugins/security_solution/common/experimental_features.ts` and in the `allowedExperimentalValues` section set:
    
    ```typescript
    tGridEnabled: true,
    ```
    andrew-goldstein committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    d3107f5 View commit details
    Browse the repository at this point in the history
  2. quick test fix

    semd authored and andrew-goldstein committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    88979a2 View commit details
    Browse the repository at this point in the history
  3. skip test for clock-icon

    semd authored and andrew-goldstein committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    c589818 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1d66a28 View commit details
    Browse the repository at this point in the history
  5. - Integrated with the Field Browser for adding / removing columns

    - removed a skipped test that is no longer applicable
    andrew-goldstein committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    d7d6c00 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a975f47 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6a7f93e View commit details
    Browse the repository at this point in the history
  8. - pr feedback

    andrew-goldstein committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    bfde95a View commit details
    Browse the repository at this point in the history