Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Observability RAC] Alerts table post-EuiDataGrid style updates (#106349) #106923

Merged
merged 1 commit into from
Jul 27, 2021

Commits on Jul 27, 2021

  1. [Observability RAC] Alerts table post-EuiDataGrid style updates (el…

    …astic#106349)
    
    ## [Observability RAC] Alerts table post-`EuiDataGrid` style updates
    
    This PR updates styles in the Observability `Alerts` table, as a follow-up to the [TGrid migrating to use `EuiDataGrid` for rendering](elastic#106199), and [this PR](elastic#105446), which improved the alerts table columns.
    
    - The `Reason` column uses up the remaining width, a follow-up task from elastic#105446
      - This task was originally tracked by elastic#105227
    - Increased the font weight and vertically aligned the `Actions` header with the other columns
    - ~Removed the `Status` column~ (EDIT: we won't remove this, per a discussion w/ UX)
    - Increased the width of the `Triggered` column
    - ~Renamed the `Duration` column to `Alert duration`~ (EDIT: we won't rename this, per a discussion w/ UX)
    - Eliminated the gap between actions
    - Added truncation to the `Reason` column
    
    ### Before
    
    ![before](https://user-images.githubusercontent.com/4459398/126430458-89440150-c10b-43b1-b0b4-2044ddfc22a8.png)
    
    ### After
    
    <img width="1280" alt="after" src="https://user-images.githubusercontent.com/4459398/126716690-be310fdf-3760-4014-998b-3c89099c2564.png">
    
    ### Desk testing
    
    - To desk test the `Observability > Alerts` page, add the following settings to `config/kibana.dev.yml`:
    
    ```
    xpack.observability.unsafe.cases.enabled: true
    xpack.observability.unsafe.alertingExperience.enabled: true
    xpack.ruleRegistry.write.enabled: true
    ```
    
    cc @mdefazio
    andrew-goldstein authored and kibanamachine committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    5b5dd83 View commit details
    Browse the repository at this point in the history