Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] [Infra] do not import types from the legacy elasticsearch package #107118

Merged
merged 2 commits into from
Jul 29, 2021
Merged

[Maps] [Infra] do not import types from the legacy elasticsearch package #107118

merged 2 commits into from
Jul 29, 2021

Conversation

mshustov
Copy link
Contributor

Summary

Use types provided by @elastic/elasticsearch package.

@mshustov mshustov added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Jul 29, 2021
@mshustov mshustov requested a review from a team as a code owner July 29, 2021 07:58
@mshustov mshustov added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jul 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@mshustov mshustov mentioned this pull request Jul 29, 2021
Closed
74 tasks
@mshustov mshustov enabled auto-merge (squash) July 29, 2021 08:10
@mshustov mshustov added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 29, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.2MB 3.2MB +100.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

weltenwort
weltenwort approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra plugin changes LGTM, thank you

@mshustov mshustov merged commit 1cfc2eb into elastic:master Jul 29, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 29, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2021
@mshustov @kibanamachine
[Maps] [Infra] do not import types from the legacy elasticsearch pack…
2e1f845 
…age (elastic#107118)

* remove elasticsearch import from infra

* remove elasticsearch import from maps
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@mshustov mshustov deleted the maps-infra-remove-elasticsearch-imports branch July 29, 2021 17:28
kibanamachine added a commit that referenced this pull request Jul 29, 2021
@kibanamachine @mshustov
[Maps] [Infra] do not import types from the legacy elasticsearch pack…
94549dc 
…age (#107118) (#107209)

* remove elasticsearch import from infra

* remove elasticsearch import from maps

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
@matschaffer matschaffer mentioned this pull request Aug 3, 2021
Merged
1 task
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@mshustov @vadimkibana
[Maps] [Infra] do not import types from the legacy elasticsearch pack…
0db58e4 
…age (elastic#107118)

* remove elasticsearch import from infra

* remove elasticsearch import from maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshustov @elasticmachine @kibanamachine @weltenwort