Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Remove references to legacy Elasticsearch types #107519

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Aug 3, 2021

Summary

Closes #107179

Remove references to elasticsearch module in Fleet.

The non-legacy elasticsearch/types module does not export these legacy errors, and I based this PR off of another one linked in the top-level tracking issue (#83910) for this cleanup in which the security team removed references to these legacy errors in their tests: #107135.

@kpollich kpollich added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 3, 2021
@kpollich kpollich requested a review from a team as a code owner August 3, 2021 12:33
@kpollich kpollich self-assigned this Aug 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kpollich kpollich enabled auto-merge (squash) August 3, 2021 14:54
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 3, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 3555e74 into elastic:master Aug 3, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 3, 2021
* Remove references to legacy elasticsearch types

* Fix types

* Fix more types
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 3, 2021
…07548)

* Remove references to legacy elasticsearch types

* Fix types

* Fix more types

Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
* Remove references to legacy elasticsearch types

* Fix types

* Fix more types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Clean up legacy elasticsearch imports
4 participants