Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [RAC] [TGrid] Implements sorting in the TGrid (#107495) #107686

Merged

Commits on Aug 4, 2021

  1. [RAC] [TGrid] Implements sorting in the TGrid (elastic#107495)

    ## Summary
    
    This PR implements sorting in the `TGrid`, per the animated gifs below:
    
    ![observability-sorting](https://user-images.githubusercontent.com/4459398/127960825-5be21a92-81c1-487d-9c62-1335495f4561.gif)
    
    _Above: Sorting in Observability, via `EuiDataGrid`'s sort popover_
    
    ![security-solution-sorting](https://user-images.githubusercontent.com/4459398/128050301-0ea9ccbc-7896-46ef-96da-17b5b6d2e34b.gif)
    
    _Above: Sorting and hiding columns in the Security Solution via `EuiDataGrid`'s column header actions_
    
    ## Details
    
    * Sorting is disabled for non-aggregatble fields
    * This PR resolves the `Sort [Object Object]` TODO described [here](elastic#106199 (comment))
    * ~This PR restores the column header tooltips where the TGrid is used in the Security Solution~
    
    ## Desk testing
    
    To desk test this PR, you must enable feature flags in the Observability and Security Solution:
    
    - To desk test the `Observability > Alerts` page, add the following settings to `config/kibana.dev.yml`:
    
    ```
    xpack.observability.unsafe.cases.enabled: true
    xpack.observability.unsafe.alertingExperience.enabled: true
    xpack.ruleRegistry.write.enabled: true
    ```
    
    - To desk test the TGrid in the following Security Solution, edit `x-pack/plugins/security_solution/common/experimental_features.ts` and in the `allowedExperimentalValues` section set:
    
    ```typescript
    tGridEnabled: true,
    ```
    
    cc @mdefazio
    andrew-goldstein committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    30ddff5 View commit details
    Browse the repository at this point in the history