Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution, Timelines] Replace more legacy elasticsearch types #108087

Merged
merged 2 commits into from
Aug 11, 2021
Merged

[Security Solution, Timelines] Replace more legacy elasticsearch types #108087

merged 2 commits into from
Aug 11, 2021

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Aug 10, 2021

Summary

Followup to #107226, as a few more imports snuck through while this was in review.

For maintainers

@rylnd rylnd added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 labels Aug 10, 2021
@rylnd rylnd self-assigned this Aug 10, 2021
@rylnd rylnd requested review from a team as code owners August 10, 2021 18:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

spong
spong approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you for the additional cleanup @rylnd!

@rylnd
Handle possibly undefined response fields
8bb736c 
These are both number | undefined, so we default to 0 if we need a
value. Fixes the type errors resulting from the previous type changes.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +3.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 306.6KB 306.8KB +204.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rylnd

@rylnd rylnd added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 11, 2021
@rylnd rylnd merged commit 9476571 into elastic:master Aug 11, 2021
@rylnd rylnd deleted the remove-more-legacy-types branch August 11, 2021 16:02
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2021
@rylnd @kibanamachine
[Security Solution, Timelines] Replace more legacy elasticsearch types (
0db83f0 
elastic#108087)

* Replace more legacy elasticsearch types

* Handle possibly undefined response fields

These are both number | undefined, so we default to 0 if we need a
value. Fixes the type errors resulting from the previous type changes.
@kibanamachine kibanamachine mentioned this pull request Aug 11, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@mshustov mshustov mentioned this pull request Aug 11, 2021
Closed
74 tasks
kibanamachine added a commit that referenced this pull request Aug 11, 2021
@kibanamachine @rylnd
[Security Solution, Timelines] Replace more legacy elasticsearch types (
4994020 
#108087) (#108229)

* Replace more legacy elasticsearch types

* Handle possibly undefined response fields

These are both number | undefined, so we default to 0 if we need a
value. Fixes the type errors resulting from the previous type changes.

Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees

@rylnd rylnd

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rylnd @elasticmachine @kibanamachine @spong @kqualters-elastic