Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task Manager] [8.0] Remove xpack.task_manager.index #108111

Merged
merged 3 commits into from
Aug 11, 2021
Merged

[Task Manager] [8.0] Remove xpack.task_manager.index #108111

merged 3 commits into from
Aug 11, 2021

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Aug 10, 2021 •
edited
Loading

Resolves #102076
Related to #101964

Note: This PR should only live in 8.0 and not in 7.x

This setting is currently deprecated in 7.x and this PR removes it from 8.0.

Release note

Details

The xpack.task_manager.index setting is no longer supported as a configuration option.

Impact

Users will need to remove xpack.task_manager.index from their Kibana config or Kibana will fail to start.

@chrisronline chrisronline changed the title Remove support for the config field index [Task Manager] [8.0] Remove xpack.task_manager.index Aug 11, 2021
@chrisronline chrisronline marked this pull request as ready for review August 11, 2021 16:42
@chrisronline chrisronline requested a review from a team as a code owner August 11, 2021 16:42
@chrisronline chrisronline added 8.0.0 Breaking Change Feature:Task Manager release_note:breaking Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Aug 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@chrisronline chrisronline added v8.0.0 and removed 8.0.0 labels Aug 11, 2021
ymao1
ymao1 approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should remove the setting from the 8.0 docs as well: https://www.elastic.co/guide/en/kibana/master/task-manager-settings-kb.html

YulNaumenko
YulNaumenko approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisronline chrisronline requested a review from a team as a code owner August 11, 2021 17:54
@chrisronline chrisronline added the backport:skip This commit does not require backporting label Aug 11, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 9dce033 into elastic:master Aug 11, 2021
@chrisronline chrisronline deleted the tm/remove_index_config branch August 11, 2021 20:24
@cachedout
Copy link
Contributor

Hi @chrisronline

This change has broken the test/dev infrastructure for Observability where we depend on this setting for multiple developers to all point their Kibana instances to the same ES cluster.

I know that this has been planned for a while, but we are in the middle of our migration to CCS for our test infrastructure as a permanent work-around but that work has not yet been completed.

We've been watching the issue that were were asked to watch for status updates for these changes but didn't see any mention of this change.

I understand that it's not ideal, but is Kibana willing to temporarily revert this change for the next several weeks? We've been making steady progress on our migration but we just need more time.

cc: @kobelb

@cachedout cachedout mentioned this pull request Aug 12, 2021
Closed
14 tasks
@chrisronline
Copy link
Contributor Author

@cachedout Thanks for bringing this up! I wasn't aware of this dependency. I'll talk with the team and figure out the best path forward and update you on this PR.

@cachedout
Copy link
Contributor

Thanks, @chrisronline ! I also posted in #82020 so you can also post your reply there if it brings more visibility.

chrisronline added a commit that referenced this pull request Aug 12, 2021
@chrisronline
Revert "[Task Manager] [8.0] Remove xpack.task_manager.index (#108111…
88bda60 
…)"

This reverts commit 9dce033.
@chrisronline chrisronline mentioned this pull request Aug 12, 2021
Merged
chrisronline added a commit that referenced this pull request Aug 12, 2021
@chrisronline
Revert "[Task Manager] [8.0] Remove xpack.task_manager.index (#108111…
fb215ed 
…)" (#108398)

This reverts commit 9dce033.
@chrisronline chrisronline mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@ymao1 ymao1 ymao1 approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Breaking Change Feature:Task Manager release_note:breaking Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[8.0 only] Remove xpack.task_manager.index setting
7 participants
@chrisronline @elasticmachine @kibanamachine @cachedout @jbudz @ymao1 @YulNaumenko