Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky spaces test #117372

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Nov 3, 2021

@thomheymann thomheymann added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 3, 2021
@thomheymann thomheymann marked this pull request as ready for review November 3, 2021 19:01
@thomheymann thomheymann changed the title Fix flaky test Fix flaky spaces test Nov 3, 2021
@thomheymann
Copy link
Contributor Author

@elasticmachine merge upstream

@thomheymann thomheymann added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Nov 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@thomheymann thomheymann requested a review from a team November 3, 2021 19:03
@thomheymann thomheymann added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 3, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner
Copy link
Contributor

jportner commented Nov 3, 2021

This test has a history of flakiness, but the flaky test runner hasn't given us any issues this time around.

I'm a bit concerned that we haven't found whatever might have been causing the flaky behavior before. However, all of the old builds are from Jenkins and long since deleted, so we don't have much to go off of.
I looked around a bit in the popover code and nothing really stood out to me tbh.

I guess we can go ahead and merge this and hope for the best, at least if it starts failing again we'll have permanent Buildkite data from the new test failures.

P.S. we should backport this to 8.0 and 7.16, I'll add the labels

@thomheymann thomheymann merged commit 8872723 into elastic:main Nov 4, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 4, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 4, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Thom Heymann <190132+thomheymann@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 8, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Nov 8, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Thom Heymann <190132+thomheymann@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.16.1 v8.0.0 v8.1.0
Projects
None yet
4 participants