-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky spaces test #117372
Fix flaky spaces test #117372
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-security (Team:Security) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
This test has a history of flakiness, but the flaky test runner hasn't given us any issues this time around. I'm a bit concerned that we haven't found whatever might have been causing the flaky behavior before. However, all of the old builds are from Jenkins and long since deleted, so we don't have much to go off of. I guess we can go ahead and merge this and hope for the best, at least if it starts failing again we'll have permanent Buildkite data from the new test failures. P.S. we should backport this to 8.0 and 7.16, I'll add the labels |
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Fixes #99581
Result from flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/140#3d388c2c-2f3b-4598-966d-e7316add51a9Result from flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/144#3ae7039d-8ce9-4f91-80a2-e809b6090665