Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] prefer ECS field names for HTTP and URL #118485

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

axw
Copy link
Member

@axw axw commented Nov 14, 2021

Summary

In the span flyout, prefer ECS fields for span HTTP and URL properties. Fall back to the old field names for backwards compatibility with old data.

In 7.14 we started copying span.http.* fields to their ECS equivalents: http.* and url*.
We continued populating the old names for backwards compatibility, but will cease doing so from 8.0 on.

See also elastic/apm-server#5995

Checklist

- [ ] Unit or functional tests were updated or added to match the most common scenarios (Are there any?)

For maintainers

@axw axw added Team:APM All issues that need APM UI Team support v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed backport-v8.0.0 labels Nov 14, 2021
@axw axw force-pushed the apm-span-http-fields branch 2 times, most recently from 3713b0c to 986dc84 Compare November 15, 2021 00:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB +395.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@axw axw marked this pull request as ready for review November 15, 2021 03:02
@axw axw requested a review from a team as a code owner November 15, 2021 03:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 15, 2021
@axw axw merged commit 1a321bc into elastic:main Nov 15, 2021
@axw axw deleted the apm-span-http-fields branch November 15, 2021 22:57
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 15, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 16, 2021
Co-authored-by: Andrew Wilkins <axw@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 16, 2021
…igrate-away-from-injected-css-js

* 'main' of github.com:elastic/kibana: (221 commits)
  [Reporting] Add log level to config (elastic#118319)
  [Metrics UI] Skip failing waffle chart color palette test (elastic#118527)
  [APM] chore: Unify naming of 'apm/scripts/**/*' with snake_case (elastic#118328)
  skip flaky suites (elastic#99581, elastic#118356, elastic#118474)
  [Alerting] Initial implementation of alerting task `cancel()` (elastic#114289)
  chore(NA): creates pkg_npm_types bazel rule (elastic#116465)
  skip flaky suite (elastic#116892)
  Bump chromedriver to 95.0.0 (elastic#116724)
  [Data visualizer] Improve design of expanded rows (elastic#118125)
  [APM] prefer ECS field names for HTTP and URL (elastic#118485)
  Update query_debugging_in_development_and_production.md (elastic#118491)
  [Uptime] adjust Elastic Synthetics integration functional tests (elastic#118163)
  [kbn/rule-data-utils] add submodules and require public use them (elastic#117963)
  [DOCS] Refresh APM correlation screenshots (elastic#116723) (elastic#118577)
  Handles ns to ms conversion for event loop delay metrics (elastic#118447)
  [Cases] Rename functional tests folder (elastic#118490)
  dummy commit
  skip flaky suite (elastic#118593)
  Improve workpad schema validation (elastic#97838)
  skip flaky suite (elastic#118584)
  ...

# Conflicts:
#	src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
mbondyra pushed a commit to mbondyra/kibana that referenced this pull request Nov 19, 2021
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants