[XY] Fixes percentage mode behavior when multiple metrics are placed on the same axis #121610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
Feature:XYAxis
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
|
@elasticmachine merge upstream |
dej611
reviewed
Dec 22, 2021
src/plugins/vis_types/xy/public/utils/compute_percentage_data.ts
Outdated
Show resolved
Hide resolved
dej611
approved these changes
Dec 22, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@stratoula Not sure whether that's a new bug or not, but in case of percentiles the percentage formatting is dropped (low priority issue): |
|
@stratoula That would be great, thanks. Besides that it seems to work just fine 👍 |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
stratoula
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 10, 2022
…on the same axis (elastic#121610) * Fixes the stacked part for percentage mode * Fixes the percentages mode * Add unit tests * Address performance related comment Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 2d41a34)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 10, 2022
…on the same axis (elastic#121610) * Fixes the stacked part for percentage mode * Fixes the percentages mode * Add unit tests * Address performance related comment Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 2d41a34)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 10, 2022
…on the same axis (#121610) (#122546) * Fixes the stacked part for percentage mode * Fixes the percentages mode * Add unit tests * Address performance related comment Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 2d41a34) Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jan 10, 2022
…on the same axis (#121610) (#122547) * Fixes the stacked part for percentage mode * Fixes the percentages mode * Add unit tests * Address performance related comment Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 2d41a34) Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
…on the same axis (elastic#121610) * Fixes the stacked part for percentage mode * Fixes the percentages mode * Add unit tests * Address performance related comment Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #121508
Closes #122496
This PR fixes the ratios that are computed for the percentage mode if multiple metrics are placed on the same axis.
With small multiples
With split series
Checklist