[Console] Add option to disable keyboard shortcuts #128887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mibragimov
added
release_note:enhancement
Feature:Console
sabarasaba
reviewed
Apr 1, 2022
There was a problem hiding this comment.
Thanks for having a go at this @mibragimov! I've had a look at the code and left a few questions, tested locally and works just fine!
src/plugins/console/public/application/components/settings_modal.tsx
Outdated
Show resolved
Hide resolved
...ins/console/public/application/containers/editor/legacy/console_editor/keyboard_shortcuts.ts
Outdated
Show resolved
Hide resolved
mibragimov
force-pushed
the
console/disable-keyboard-shortcut
branch
from
e50a0aa
to
c8de9a2
Compare
|
@elasticmachine merge upstream |
|
expected head sha didn’t match current head ref. |
mibragimov
added
the
Team:Kibana Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
|
@elasticmachine merge upstream |
sabarasaba
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Thanks for addressing all the feedback @mibragimov! I've re-tested everything and works fine, left a comment about a line that we're ignoring linting from. But I'm gonna go ahead and approve it for now and wait for clarification on that.
src/plugins/console/public/application/models/legacy_core_editor/legacy_core_editor.ts
Show resolved
Hide resolved
|
Also |
alexwizp
reviewed
Apr 7, 2022
src/plugins/console/public/application/components/settings_modal.tsx
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Apr 7, 2022
...ins/console/public/application/containers/editor/legacy/console_editor/keyboard_shortcuts.ts
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Apr 7, 2022
src/plugins/console/public/application/containers/main/main.tsx
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Apr 7, 2022
mibragimov
force-pushed
the
console/disable-keyboard-shortcut
branch
from
df389d4
to
1470c91
Compare
|
@sabarasaba @alexwizp Thanks for the review! I've addressed the comments with 1470c91. Do you mind having another look? |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mibragimov |
alexwizp
approved these changes
Apr 13, 2022
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 13, 2022
…rint-media-attempt-2 * 'main' of github.com:elastic/kibana: (75 commits) [Lens] Hide disabled toolbar entries (elastic#129994) Fix explore tables don't display data when a global filter is applied (elastic#130024) [Console] Add option to disable keyboard shortcuts (elastic#128887) [Discover] Update refreshOnClick flaky test (elastic#130001) [Uptime] remove latency limit warnings when using monitor management (elastic#129597) [Security Solution] [ReponseOps] Executes Cases Cypress test when there is a change on cases plugin (elastic#129992) Paramaterized Discover tests (elastic#129684) [Security Solution][Investigations] - Minor bug fixes (elastic#130054) [DOCS} Adds technical preview to Lens annotations (elastic#130058) [Security solution] [Endpoint] Revisit blocklist wrong labels (elastic#128773) [Security Solutions] Adds API docs for value lists (elastic#129962) [CI] Move jest tests to spot instances, and fix spot retries in PRs (elastic#130045) chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130051) [SecuritySolution] Remove the cell hovers actions for agent status (elastic#130042) Upgrade RxJS to 7 (elastic#129087) [SecuritySolution] Clean up CaseContext (elastic#130036) Revert "chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021)" Use RuleDataReader to query for threshold signal history (elastic#129763) Remove securityRulesCancelEnabled setting and set shorter default timeouts (elastic#129769) Upgrade EUI to v54.0.0 (elastic#129653) ... # Conflicts: # x-pack/plugins/screenshotting/server/formats/pdf/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48410
Summary
This PR adds support for disabling keyboard shortcuts in Console. Shortcuts can be enabled/disabled in the settings modal.