Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory][ECO] Enable elastic entity model from inventory #193557

Merged
merged 9 commits into from
Sep 23, 2024
Merged

[Inventory][ECO] Enable elastic entity model from inventory #193557

merged 9 commits into from
Sep 23, 2024

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Sep 20, 2024 •
edited by kibanamachine
Loading

Summary

closes #192328

Note

Empty state will be handled in a different ticket

Checklist

Enable with permissions

Screen.Recording.2024-09-20.at.15.03.29.mov
Screen.Recording.2024-09-23.at.12.23.35.mov

Enable without permissions

Screen.Recording.2024-09-20.at.15.02.44.mov
Screen.Recording.2024-09-23.at.12.26.52.mov

TODO

  • add dark screenshot of inventory

@kpatticha kpatticha requested a review from a team as a code owner September 20, 2024 12:24
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 20, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 20, 2024
@kpatticha kpatticha requested a review from a team September 23, 2024 09:30
cauemarcondes
cauemarcondes approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit.

x-pack/plugins/observability_solution/inventory/public/hooks/use_theme.ts Outdated Show resolved Hide resolved
iblancof
iblancof approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@iblancof iblancof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the recording, it looks like the loading state lasted about 25 seconds in this case.

Should we consider alerting the user that it may take some time? I mention this to ensure they don't mistakenly think something is malfunctioning. However, it's possible that our users are already aware that some processes may have longer loading times.

@cauemarcondes
Copy link
Contributor

From the recording, it looks like the loading state lasted about 25 seconds in this case.

Should we consider alerting the user that it may take some time? I mention this to ensure they don't mistakenly think something is malfunctioning. However, it's possible that our users are already aware that some processes may have longer loading times.

@kpatticha alongside with this, what happens when a user refreshes the page while the process is still running?

@kpatticha
Copy link
Contributor Author

From the recording, it looks like the loading state lasted about 25 seconds in this case.

Should we consider alerting the user that it may take some time? I mention this to ensure they don't mistakenly think something is malfunctioning. However, it's possible that our users are already aware that some processes may have longer loading times.

that's a good point. I'll reach out to eem first to see if that's can be improved and if not I'll check with Roshan and Karolina

@cauemarcondes as long as the enablement endpoint has been called it will continue running in the background and start the data tranforms. Once the user reloads the page, he will see the enablement page again until the GET enablement endpoint returns true.

The downside is that he can still clicks on the Enable button but there is no way for us to know if he already started the process. He might see errors from EEM handling this case.

@cauemarcondes
Copy link
Contributor

The downside is that he can still clicks on the Enable button but there is no way for us to know if he already started the process. He might see errors from EEM handling this case.

This is an edge case, we can think about this later on. Thanks for checking it.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 23, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 143 150 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 59.8KB 66.1KB +6.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
inventory 9.5KB 9.7KB +143.0B
Unknown metric groups

miscellaneous assets size

id before after diff
inventory 0.0B 351.7KB ⚠️ +351.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpatticha kpatticha enabled auto-merge (squash) September 23, 2024 11:25
@kpatticha kpatticha merged commit b5a061e into elastic:main Sep 23, 2024
29 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2024
@kpatticha
[Inventory][ECO] Enable elastic entity model from inventory (elastic#…
140bb9f 
…193557)

## Summary

closes elastic#192328

> [!Note]
>  Empty state will be handled in a different ticket
### Checklist

### Enable with permissions

https://github.com/user-attachments/assets/c7a5390b-2d7c-4897-a167-485da74ac336

https://github.com/user-attachments/assets/44e30654-04bd-42c3-9c1e-a24042b4cb40

### Enable without permissions

https://github.com/user-attachments/assets/b5f16f43-1cd4-48a7-bf04-3926b03e5a30

https://github.com/user-attachments/assets/be17ddf7-de7a-4573-b0c4-caadeece3cc5

### TODO

- [x] add dark screenshot of inventory

(cherry picked from commit b5a061e)
@kibanamachine kibanamachine mentioned this pull request Sep 23, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Sep 23, 2024
Merged
kibanamachine added a commit that referenced this pull request Sep 23, 2024
@kibanamachine @kpatticha
[8.x] [Inventory][ECO] Enable elastic entity model from inventory (#1…
e3723fe 
…93557) (#193712)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] Enable elastic entity model from inventory
(#193557)](#193557)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2024-09-23T12:01:00Z","message":"[Inventory][ECO]
Enable elastic entity model from inventory (#193557)\n\n##
Summary\r\n\r\ncloses #192328
\r\n\r\n> [!Note] \r\n> Empty state will be handled in a different
ticket\r\n### Checklist\r\n\r\n### Enable with permissions
\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/c7a5390b-2d7c-4897-a167-485da74ac336\r\n\r\n\r\nhttps://github.com/user-attachments/assets/44e30654-04bd-42c3-9c1e-a24042b4cb40\r\n\r\n\r\n\r\n\r\n###
Enable without permissions
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b5f16f43-1cd4-48a7-bf04-3926b03e5a30\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be17ddf7-de7a-4573-b0c4-caadeece3cc5\r\n\r\n\r\n\r\n###
TODO\r\n\r\n- [x] add dark screenshot of
inventory","sha":"b5a061ec64ba4246c6f476dbe192435cb896fef1","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory][ECO]
Enable elastic entity model from
inventory","number":193557,"url":"#193557
Enable elastic entity model from inventory (#193557)\n\n##
Summary\r\n\r\ncloses #192328
\r\n\r\n> [!Note] \r\n> Empty state will be handled in a different
ticket\r\n### Checklist\r\n\r\n### Enable with permissions
\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/c7a5390b-2d7c-4897-a167-485da74ac336\r\n\r\n\r\nhttps://github.com/user-attachments/assets/44e30654-04bd-42c3-9c1e-a24042b4cb40\r\n\r\n\r\n\r\n\r\n###
Enable without permissions
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b5f16f43-1cd4-48a7-bf04-3926b03e5a30\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be17ddf7-de7a-4573-b0c4-caadeece3cc5\r\n\r\n\r\n\r\n###
TODO\r\n\r\n- [x] add dark screenshot of
inventory","sha":"b5a061ec64ba4246c6f476dbe192435cb896fef1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#193557
Enable elastic entity model from inventory (#193557)\n\n##
Summary\r\n\r\ncloses #192328
\r\n\r\n> [!Note] \r\n> Empty state will be handled in a different
ticket\r\n### Checklist\r\n\r\n### Enable with permissions
\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/c7a5390b-2d7c-4897-a167-485da74ac336\r\n\r\n\r\nhttps://github.com/user-attachments/assets/44e30654-04bd-42c3-9c1e-a24042b4cb40\r\n\r\n\r\n\r\n\r\n###
Enable without permissions
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b5f16f43-1cd4-48a7-bf04-3926b03e5a30\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be17ddf7-de7a-4573-b0c4-caadeece3cc5\r\n\r\n\r\n\r\n###
TODO\r\n\r\n- [x] add dark screenshot of
inventory","sha":"b5a061ec64ba4246c6f476dbe192435cb896fef1"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
weizijun added a commit to weizijun/kibana that referenced this pull request Sep 23, 2024
@weizijun
Merge branch 'main' into add-alibaba-inference
2100828 
* main: (176 commits)
  [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420)
  Bump maximum supported package spec version to 3.2 (elastic#193574)
  [ES|QL] new pattern for `SORT` autocomplete (elastic#193595)
  [Inventory][ECO] Entities page search bar (elastic#193546)
  [Synthetics] Remove extra overview route (elastic#192449)
  [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693)
  [Migrations] Remove tests that are not applicable in 9.x (elastic#193699)
  [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017)
  [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557)
  [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562)
  [Entity Analytics] Ensuring definition transforms are managed (elastic#193408)
  [Automatic Import] Do not remove message field for unstructured logs (elastic#193678)
  [Fleet] Add missing permissions for connector package (elastic#193573)
  [Fleet] using @kbn/config-schema part 2 (outputs and other apis)  (elastic#193326)
  [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328)
  [ES|QL] Renames the textbased editor to esql editor (elastic#193521)
  [ES|QL] Update function metadata (elastic#193662)
  [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303)
  [Docs] Update Sharing docs (elastic#190318)
  [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243)
  ...

# Conflicts:
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@iblancof iblancof iblancof approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Inventory] Enable EEM from inventory
6 participants
@kpatticha @obltmachine @cauemarcondes @kibana-ci @kibanamachine @iblancof