-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple Elasticsearch nodes and sniffing #21928
Changes from all commits
bd542c2
9bb693f
1e021a1
9c76c88
55743a0
9d33df9
10d3933
99b4927
8a37e35
1207572
2898bba
227620a
d20ef23
e5087e5
cf548b0
b08264b
4df060e
f9a56c8
6261799
cc22e30
05a63c6
35cd2e9
722a1b7
337bd82
80d0941
ff92ded
283d5b4
9da7585
e119c8e
172fc41
a989832
bae59ef
d41fdbf
09600e8
3d1f707
878ed05
6c8f1f4
48127e7
146a5d1
699f66f
275a0e4
070ecd6
2bf1e65
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,7 +105,7 @@ function applyConfigOverrides(rawConfig, opts, extraCliOptions) { | |
} | ||
} | ||
|
||
if (opts.elasticsearch) set('elasticsearch.url', opts.elasticsearch); | ||
if (opts.elasticsearch) set('elasticsearch.hosts', opts.elasticsearch.split(',')); | ||
if (opts.port) set('server.port', opts.port); | ||
if (opts.host) set('server.host', opts.host); | ||
if (opts.quiet) set('logging.quiet', true); | ||
|
@@ -144,7 +144,7 @@ export default function (program) { | |
command | ||
.description('Run the kibana server') | ||
.collectUnknownOptions() | ||
.option('-e, --elasticsearch <uri>', 'Elasticsearch instance') | ||
.option('-e, --elasticsearch <uri1,uri2>', 'Elasticsearch instances') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Honestly had no idea we supported this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not related to this PR, but thoughts on removing this in 7.0? I assume these options came before you could pass arbitrary config options through the CLI. |
||
.option( | ||
'-c, --config <path>', | ||
'Path to the config file, can be changed with the CONFIG_PATH environment variable as well. ' + | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, looks like some bits fell out. Connection is missing an 'n' in the setting name.