Remove previously deprecated `elasticsearch.*` settings. #29496

azasypkin · 2019-01-29T10:24:18Z

This PR:

Removes the ability to use elasticsearch.url and requires that the user uses elasticsearch.hosts instead
Removes the ability to use elasticsearch.ssl.verify and requires that the user uses elasticsearch.ssl.verificationMode instead
Removes the ability to use elasticsearch.ssl.cert and requires that the user uses elasticsearch.ssl.certificate instead
Removes the ability to use elasticsearch.ssl.ca and requires that the user uses elasticsearch.ssl.certificateAuthorities instead
Removes the ability to use xpack.monitoring.elasticsearch.url and requires that the user uses xpack.monitoring.elasticsearch.hosts instead
Removes the ability to use xpack.monitoring.elasticsearch.ssl.verify and requires that the user uses xpack.monitoring.elasticsearch.ssl.verificationMode instead
Removes the ability to use xpack.monitoring.elasticsearch.ssl.cert and requires that the user uses xpack.monitoring.elasticsearch.ssl.certificate instead
Removes the ability to use xpack.monitoring.elasticsearch.ssl.ca and requires that the user uses xpack.monitoring.elasticsearch.ssl.certificateAuthorities instead

"Release Note: elasticsearch.url is no longer valid, elasticsearch.hosts must be used instead. In prior versions of Kibana, if no port was specified in elasticsearch.url a default of 9200 was chosen. The port in
elasticsearch.hosts is protocol dependent: https ports will use 443, and http ports will use 80."

"Release Note: elasticsearch.ssl.verify is no longer valid, elasticsearch.ssl.verificationMode must be used instead. Previously set elasticsearch.ssl.verify is equal to elasticsearch.ssl.verificationMode: full."

"Release Note: elasticsearch.ssl.cert is no longer valid, elasticsearch.ssl.certificate must be used instead."

"Release Note: elasticsearch.ssl.ca is no longer valid, elasticsearch.ssl.certificateAuthorities must be used instead."

"Release Note: xpack.monitoring.elasticsearch.url is no longer valid, xpack.monitoring.elasticsearch.hosts must be used instead. In prior versions of Kibana, if no port was specified in xpack.monitoring.elasticsearch.url a default of 9200 was chosen. The port in
xpack.monitoring.elasticsearch.hosts is protocol dependent: https ports will use 443, and http ports will use 80."

"Release Note: xpack.monitoring.elasticsearch.ssl.verify is no longer valid, xpack.monitoring.elasticsearch.ssl.verificationMode must be used instead. Previously set xpack.monitoring.elasticsearch.ssl.verify is equal to xpack.monitoring.elasticsearch.ssl.verificationMode: full."

"Release Note: xpack.monitoring.elasticsearch.ssl.cert is no longer valid, xpack.monitoring.elasticsearch.ssl.certificate must be used instead."

"Release Note: xpack.monitoring.elasticsearch.ssl.ca is no longer valid, xpack.monitoring.elasticsearch.ssl.certificateAuthorities must be used instead."

elasticmachine · 2019-01-29T10:24:20Z

Pinging @elastic/kibana-platform

elasticmachine · 2019-01-29T11:10:34Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

azasypkin · 2019-01-29T11:26:49Z

docs/migration/migrate_7_0.asciidoc

@@ -97,13 +97,6 @@ considered unique based on its persistent UUID, which is written to the path.dat

 *Impact:* The logging.useUTC flag will have to be replaced with a timezone id.  If set to true the id is `UTC`.

-[float]


note: I thought it'd make sense to join these two notes into one, let me know if you have a better wording.

azasypkin · 2019-01-29T11:27:15Z

src/legacy/core_plugins/elasticsearch/__tests__/index.js

@@ -1,97 +0,0 @@
-/*


note: tests were testing only config deprecations.

azasypkin · 2019-01-29T11:49:18Z

Hey @elastic/stack-monitoring, we've recently removed deprecated server.ssl.cert and going to remove deprecated elasticsearch.ssl.cert/ca/verify in this PR. It'd probably make sense to do the same for xpack.monitoring.elasticsearch.* for the consistency sake in 7.0, what do you think?

ycombinator · 2019-01-29T18:07:49Z

Regarding the monitoring settings, we need to make sure the new (replacement) settings are supported in 6.7 at least (if not earlier) so users have a chance to move over to them first. Then we can remove them in 7.0. Even then, it's rather short notice which is not ideal but it's the least we should do at this point. /cc @chrisronline

azasypkin · 2019-01-29T18:27:31Z

Regarding the monitoring settings, we need to make sure the new (replacement) settings are supported in 6.7 at least (if not earlier) so users have a chance to move over to them first.

If I'm not mistaken xpack.monitoring.elasticsearch.ssl.ca, xpack.monitoring.elasticsearch.ssl.cert and xpack.monitoring.elasticsearch.ssl.verify have been deprecated since 5.5 and xpack.monitoring.elasticsearch.hosts since 6.6.

chrisronline · 2019-01-29T18:29:37Z

Yes @azasypkin that's correct.

Can we just update this PR to remove those deprecations and add the steps to the 7.0 migration doc? Or should we do it in another PR?

azasypkin · 2019-01-29T18:36:48Z

Can we just update this PR to remove those deprecations and add the steps to the 7.0 migration doc? Or should we do it in another PR?

These settings are so closely interconnected that I'd do it in this PR (copy-paste basically) unless there are any objections?

chrisronline · 2019-01-29T18:39:08Z

@azasypkin Agreed. Thanks!

spalger

LGTM

elasticmachine · 2019-01-30T08:34:34Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

chrisronline

LGTM!

Remove previously deprecated elasticsearch.* settings.

0734b06

azasypkin added release_note:breaking Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 labels Jan 29, 2019

azasypkin requested review from spalger and epixa January 29, 2019 11:26

azasypkin commented Jan 29, 2019

View reviewed changes

azasypkin mentioned this pull request Jan 29, 2019

Introduce Elasticsearch service. #28344

Merged

spalger approved these changes Jan 29, 2019

View reviewed changes

Drop deprecated xpack.monitoring.elasticsearch.* settings.

f16104a

azasypkin requested a review from chrisronline January 30, 2019 07:59

chrisronline approved these changes Jan 30, 2019

View reviewed changes

azasypkin added the Team:Monitoring Stack Monitoring team label Jan 30, 2019

azasypkin merged commit 86a17bf into elastic:master Jan 30, 2019

azasypkin deleted the issue-xxx-remove-deprecated-es-settings branch January 30, 2019 15:21

ycombinator mentioned this pull request Feb 2, 2019

Update docker image with kibana settings removals elastic/kibana-docker#128

Merged

This was referenced Feb 4, 2019

[DOCS] Clarify deprecation of Kibana settings #29979

Closed

[DOCS] Add deprecated monitoring settings #30012

Closed

[DOCS] New kibana settings are not documented as breaking changes #30364

Closed

lukeelmers mentioned this pull request Dec 2, 2021

elasticsearch.url isn't flagged as critical deprecation in Upgrade Assistant #120246

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove previously deprecated `elasticsearch.*` settings. #29496

Remove previously deprecated `elasticsearch.*` settings. #29496

azasypkin commented Jan 29, 2019 •

edited

Loading

elasticmachine commented Jan 29, 2019

elasticmachine commented Jan 29, 2019

azasypkin Jan 29, 2019

azasypkin Jan 29, 2019

azasypkin commented Jan 29, 2019

ycombinator commented Jan 29, 2019 •

edited

Loading

azasypkin commented Jan 29, 2019

chrisronline commented Jan 29, 2019

azasypkin commented Jan 29, 2019

chrisronline commented Jan 29, 2019

spalger left a comment

elasticmachine commented Jan 30, 2019

chrisronline left a comment

		@@ -97,13 +97,6 @@ considered unique based on its persistent UUID, which is written to the path.dat

		Impact: The logging.useUTC flag will have to be replaced with a timezone id. If set to true the id is `UTC`.

		[float]

Remove previously deprecated elasticsearch.* settings. #29496

Remove previously deprecated elasticsearch.* settings. #29496

Conversation

azasypkin commented Jan 29, 2019 • edited Loading

elasticmachine commented Jan 29, 2019

elasticmachine commented Jan 29, 2019

💚 Build Succeeded

azasypkin Jan 29, 2019

Choose a reason for hiding this comment

azasypkin Jan 29, 2019

Choose a reason for hiding this comment

azasypkin commented Jan 29, 2019

ycombinator commented Jan 29, 2019 • edited Loading

azasypkin commented Jan 29, 2019

chrisronline commented Jan 29, 2019

azasypkin commented Jan 29, 2019

chrisronline commented Jan 29, 2019

spalger left a comment

Choose a reason for hiding this comment

elasticmachine commented Jan 30, 2019

💚 Build Succeeded

chrisronline left a comment

Choose a reason for hiding this comment

Remove previously deprecated `elasticsearch.*` settings. #29496

Remove previously deprecated `elasticsearch.*` settings. #29496

azasypkin commented Jan 29, 2019 •

edited

Loading

ycombinator commented Jan 29, 2019 •

edited

Loading