Fix/3286 #3369
Merged
Fix/3286 #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. One thing though, why not just add the date field type to the average too? |
|
If you're adding average, probably makes sense to add percentile, standard deviation etc too. eg. want to analyse how closely events happened to a target date |
|
I don't think average or std deviation will produce useful data. Percentiles, maybe. I'll check it out |
spalger
added a commit
that referenced
this pull request
Mar 17, 2015
|
Merged this for now to get the bootstrap fixes in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3286
Allows
'date'as a compatible field type for the min and max aggregation. Beyond adding'date'to the field type filter, field formatters needed to support metric values that are dates. Now, when a metric agg runs on a date field, the formatter for that field is used on the metric value.