[Lens] Disable saving visualization until there are no changes to the document #52982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majagrubic
changed the title
majagrubic
force-pushed
the
lens-do-not-save
branch
2 times, most recently
from
469c829
to
ce39b99
Compare
… document Adding unit test for new functionality Fixing type error Removing unnecessary act statements Removing unnecessary assertion
majagrubic
force-pushed
the
lens-do-not-save
branch
from
ecda30a
to
581c8ce
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
majagrubic
added
Team:Visualizations
|
@elasticmachine merge upstream |
|
I think the CI fails due to some Github error: |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Jenkins, test this |
wylieconlon
approved these changes
Dec 18, 2019
| const isSaveable = lastKnownDoc && core.application.capabilities.visualize.save; | ||
| const isSaveable = | ||
| lastKnownDoc && | ||
| lastKnownDoc.expression.length > 0 && |
There was a problem hiding this comment.
This test looks like it could throw if expression is null instead of ""
There was a problem hiding this comment.
According to the type definition, it will never be null, only string:
It doesn't make sense to add a null check here without changing the type definition, and I wasn't feeling confident doing so. Thoughts?
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 30, 2019
…le-saved-objects * 'master' of github.com:elastic/kibana: (250 commits) Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161) Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775) [APM] Transaction page throws unhandled exception if transactions doesn't have `http.request` (elastic#53760) Licensing plugin functional tests (elastic#53580) [Lens] Disable saving visualization until there are no changes to the document (elastic#52982) [Monitoring] Added safeguard for some EUI components (elastic#53318) [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605) Display changed field formats without requiring hard page refresh. (elastic#53746) Upgrade EUI to v17.3.1 (elastic#53655) [APM] Fix missing apm indicies (elastic#53541) Disable inspector for timelion (elastic#53747) Clean up search servie (elastic#53701) [Dashboard] Grid: removing double handler (elastic#53707) Remove SavedObjectRegistryProvider from codebase (elastic#53455) Move ui/courier into data shim plugin (elastic#52359) ...
This was referenced Jan 2, 2020
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jan 3, 2020
… document (elastic#52982) Adding unit test for new functionality Fixing type error Removing unnecessary act statements Removing unnecessary assertion Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
majagrubic
pushed a commit
that referenced
this pull request
Jan 3, 2020
… document (#52982) (#53947) Adding unit test for new functionality Fixing type error Removing unnecessary act statements Removing unnecessary assertion Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 8, 2020
… document (elastic#52982) Adding unit test for new functionality Fixing type error Removing unnecessary act statements Removing unnecessary assertion Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't allow "Save" on empty Lens visualization if there is nothing to save.
Fixes: #52801
(Note: if there were embeddables with an empty visualization already created, they will stay empty.)
Really small change, but had to update a few specs, to mock
Documentproperly.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsFor maintainers