Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce visTypeTimeseries bundle size #64631

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Apr 28, 2020

Summary

Part of :

loads some components lazily:
Reduces the plugin bundle size from 4Mb to 1.6Mb.

For maintainers

@mshustov mshustov added performance Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov marked this pull request as ready for review April 28, 2020 12:16
@mshustov mshustov requested review from a team and flash1293 April 28, 2020 12:16
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome and TSVB still renders fine both in editor and on dashboards. LGTM 👍

@mshustov mshustov merged commit 8bb67f2 into elastic:master Apr 29, 2020
@mshustov mshustov deleted the slim-vis_type_timeseries branch April 29, 2020 10:00
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 29, 2020
* load visualizations code lazily

* load VisEditor lazily
mshustov added a commit that referenced this pull request Apr 29, 2020
* load visualizations code lazily

* load VisEditor lazily
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 29, 2020
* master:
  [ML] Changes Machine learning overview UI text (elastic#64625)
  [Uptime] Migrate client to New Platform (elastic#55086)
  Slim vis type timeseries (elastic#64631)
  [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 29, 2020
* alerting/np-migration: (64 commits)
  [ML] Changes Machine learning overview UI text (elastic#64625)
  [Uptime] Migrate client to New Platform (elastic#55086)
  Slim vis type timeseries (elastic#64631)
  [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510)
  removed unneeded dep and file
  [SIEM] Create template timeline (elastic#63136)
  load react component lazily in so management section (elastic#64285)
  Cleanup .eslingignore and add target (elastic#64617)
  [Ingest] Support yaml variables in datasource (elastic#64459)
  typescript-ify portions of src/optimize (elastic#64688)
  [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546)
  Consolidate downloading plugin bundles to bootstrap script (elastic#64685)
  [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230)
  chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292)
  [Maps] fix edit filter (elastic#64586)
  [SIEM][Detections] Adds large list support using REST endpoints
  Replace a number of any-ed styled(eui*) with accurate types (elastic#64555)
  [Endpoint] Recursive resolver children (elastic#61914)
  [ML] Fix new job wizard with multiple indices (elastic#64567)
  Use short URLs for legacy plugin deprecation warning (elastic#64540)
  ...
@lizozom lizozom changed the title Slim vis type timeseries Reduce visTypeTimeseries bundle size Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants