Index pattern management to Kibana platform #65026

mattkime · 2020-05-03T20:00:46Z

Summary

In this PR:

Index Pattern Management UI moves into its own plugin
ui/scripting_languages functionality is moved into the Index Pattern Management plugin
ui/field_editor is moved into the Index Pattern Management plugin
the url structure changes
- /management/kibana/index_patterns => /management/kibana/indexPatterns (to match app id)
- /management/kibana/index_patterns/:id => /management/kibana/indexPatterns/patterns/:id - as there were previously two app level urls previously, /management/kibana/index_patterns and /management/kibana/index_pattern
Remove angular routing, add react routing and related data loading
change namespace for localized strings

Todo

implement breadcrumbs
verify badge functionality is unchanged
verify doc titles
fix tests
Verify user w/o permissions is handled correctly.
Time field css, fix png references

Follow ups:

Remove index pattern refresh / delete when user has read only privs - Space privilege "Index pattern management" read still shows delete button #53682 (bug currently in master)
Simplify component dependencies with KibanaContext

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

Dev Docs

Field Format Editors API migrated to Kibana Platform

Field format editors (used by index pattern management) are no longer added via the field formatters registry, ui/registry/field_format_editors, and are now added via the indexPatternManagement plugin.

elasticmachine · 2020-05-04T03:51:50Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

src/plugins/index_pattern_management/public/management_app/mount_management_section.tsx

…id scripts

src/plugins/index_pattern_management/public/management_app/mount_management_section.tsx

...onents/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.test.tsx

rudolf

👍 For Platform changes

andrew-goldstein

Verified locally by creating a new space (which has no Kibana index patterns), visiting the Network page, and clicking the Configure index patterns button to navigate to the Index pattern management page:

LGTM

mattkime · 2020-05-15T22:01:26Z

@lukeelmers I'm looking into maintaining backwards compatibility in urls

lukeelmers · 2020-05-15T22:35:03Z

I'm looking into maintaining backwards compatibility in urls

@mattkime 👍 I agree the value of preserving these is debatable, but it feels like the right thing to do if it's possible without a huge effort.

we'd just need to restore some of the angular routing and turn it into redirects.

@flash1293 How did y'all end up handling BWC for URLs? Is this via the kibana_legacy plugin?

mattkime · 2020-05-15T22:37:56Z

I think I found a clue - kibanaLegacy.forwardApp

peteharverson

ML edit LGTM

cchaos

Thanks! SASS files are much cleaner, though I didn't run the actual branch.

mattkime · 2020-05-18T13:50:28Z

@elasticmachine merge upstream

mattkime · 2020-05-18T13:54:46Z

@lukeelmers I believe I addressed all your points.

jonathan-buttner

Only SIEM changes, so 👍

ThomThomson

Kibana app changes LGTM
Tested locally in chrome 81 on OSX

kibanamachine · 2020-05-19T02:41:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7edfc27

History

💚 Build #48664 succeeded 800965d
💚 Build #48540 succeeded 497638c
💚 Build #48536 succeeded c959006
💔 Build #48510 failed e78faf7
💚 Build #48468 succeeded 354cc16

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lukeelmers

Updates LGTM! Tested locally (chrome, mac os), and everything seems to be working as expected (including the redirects... thanks for doing those!) 🚀

* index pattern management to kibana platform

* master: (24 commits) [APM] agent config 'profiling_inferred_spans_min_duration' default value is '0ms' but the min value in the field is '1ms' (elastic#66886) [Canvas] Fix flaky custom element functional tests (elastic#65908) Fix IE specific flexbox min-height issue (elastic#66555) [Discover] Unskip doc link functional test (elastic#66884) Index pattern management to Kibana platform (elastic#65026) Warning and link to support matrix for IE11 (elastic#66512) [Reporting] Consolidate Server Type Defs, move some out of Legacy (elastic#66144) [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828) [Endpoint] Encode the index of the alert in the id response (elastic#66919) [services/testSubjects] reduce retry usage, add waitForEnabled (elastic#66538) [DOCS] Identifies cloud settings for APM (elastic#66935) [SIEM][CASE] Fix configuration's page user experience (elastic#66029) Resolver: Display node 75% view submenus (elastic#64121) [SIEM] Cases] Capture timeline click and open timeline in case view (elastic#66327) [APM] Lowercase agent names so icons work (elastic#66824) [dev/cli] add support for --no-cache (elastic#66837) [Ingest Manager] Better handling of package installation problems (elastic#66541) [ML] Enhances api docs for modules endpoints (elastic#66738) dont hide errors (elastic#66764) [RFC] Global search API (elastic#64284) ...

* index pattern management to kibana platform Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

mattkime added 4 commits May 3, 2020 14:59

worrk in progress - mostly working

35e4504

eslint fixes

3c7c3ba

update i18n

701c88c

comment cleanup, fix functional tests

f0f3ca5

mattkime added the Team:AppArch label May 4, 2020

mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages v8.0.0 v7.9.0 labels May 4, 2020

elastic deleted a comment from kibanamachine May 4, 2020

mattkime added 3 commits May 3, 2020 23:31

Merge branch 'master' into index_pattern_management_ui_kibana_platform

f2cdad9

fix create index pattern functional test

6141b7f

fix import references

a8685e9

VladLasitsa suggested changes May 5, 2020

View reviewed changes

src/plugins/index_pattern_management/public/management_app/mount_management_section.tsx Show resolved Hide resolved

mattkime and others added 8 commits May 5, 2020 21:23

fix tests, minor cleanups

5ba8c3f

Merge branch 'master' into index_pattern_management_ui_kibana_platform

5ad50eb

fix url

bc96e16

Merge branch 'master' into index_pattern_management_ui_kibana_platform

8b3f39a

Merge branch 'master' into index_pattern_management_ui_kibana_platform

2932a5c

fix test: management scripted fields should not allow saving of inval…

ad28f0e

…id scripts

fix JEST, fix types

5d8acd5

fixed X-Pack Chrome Functional tests / Group 2

f33576b

alexwizp reviewed May 6, 2020

View reviewed changes

src/plugins/index_pattern_management/public/management_app/mount_management_section.tsx Outdated Show resolved Hide resolved

alexwizp reviewed May 6, 2020

View reviewed changes

...onents/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.test.tsx Show resolved Hide resolved

VladLasitsa added 2 commits May 6, 2020 16:03

Fixed types

5f82b25

Fixed another one test from X-Pack Chrome Functional tests / Group 2

6119a09

VladLasitsa self-requested a review May 6, 2020 13:08

rudolf approved these changes May 15, 2020

View reviewed changes

kertal mentioned this pull request May 15, 2020

[NP] Migrate uiSettings owned by Kibana app #64321

Merged

7 tasks

Merge branch 'master' into index_pattern_management_ui_kibana_platform

354cc16

andrew-goldstein approved these changes May 15, 2020

View reviewed changes

mattkime added 5 commits May 15, 2020 21:07

fix scss

f1f6680

Merge branch 'master' into index_pattern_management_ui_kibana_platform

461069e

add url forwarding from old url setup

e78faf7

typescript fix

c959006

rename function, impoved snapshots

497638c

peteharverson approved these changes May 18, 2020

View reviewed changes

cchaos approved these changes May 18, 2020

View reviewed changes

Merge branch 'master' into index_pattern_management_ui_kibana_platform

800965d

jonathan-buttner approved these changes May 18, 2020

View reviewed changes

ThomThomson approved these changes May 18, 2020

View reviewed changes

pass link to painless docs

7edfc27

lukeelmers approved these changes May 19, 2020

View reviewed changes

mattkime merged commit f7181a9 into elastic:master May 19, 2020

mattkime mentioned this pull request May 19, 2020

[7.x] Index pattern management to Kibana platform (#65026) #66954

Merged

mattkime added a commit to mattkime/kibana that referenced this pull request May 19, 2020

Index pattern management to Kibana platform (elastic#65026)

14caaab

* index pattern management to kibana platform

mattkime added a commit that referenced this pull request May 19, 2020

Index pattern management to Kibana platform (#65026) (#66954)

9cf400b

* index pattern management to kibana platform Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Dosant mentioned this pull request May 26, 2020

Fix "Could not locate that index-pattern" recreate link is not working #67280

Merged

1 task

kibanamachine mentioned this pull request Feb 9, 2022

[data view management] Fix set default data view permissions check #124897

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Index pattern management to Kibana platform #65026

Index pattern management to Kibana platform #65026

mattkime commented May 3, 2020 •

edited

Loading

elasticmachine commented May 4, 2020

rudolf left a comment

andrew-goldstein left a comment

mattkime commented May 15, 2020

lukeelmers commented May 15, 2020

mattkime commented May 15, 2020

peteharverson left a comment

cchaos left a comment

mattkime commented May 18, 2020

mattkime commented May 18, 2020

jonathan-buttner left a comment

ThomThomson left a comment

kibanamachine commented May 19, 2020

lukeelmers left a comment

Index pattern management to Kibana platform #65026

Index pattern management to Kibana platform #65026

Conversation

mattkime commented May 3, 2020 • edited Loading

Summary

Checklist

For maintainers

Dev Docs

Field Format Editors API migrated to Kibana Platform

elasticmachine commented May 4, 2020

rudolf left a comment

Choose a reason for hiding this comment

andrew-goldstein left a comment

Choose a reason for hiding this comment

mattkime commented May 15, 2020

lukeelmers commented May 15, 2020

mattkime commented May 15, 2020

peteharverson left a comment

Choose a reason for hiding this comment

cchaos left a comment

Choose a reason for hiding this comment

mattkime commented May 18, 2020

mattkime commented May 18, 2020

jonathan-buttner left a comment

Choose a reason for hiding this comment

ThomThomson left a comment

Choose a reason for hiding this comment

kibanamachine commented May 19, 2020

💚 Build Succeeded

History

lukeelmers left a comment

Choose a reason for hiding this comment

mattkime commented May 3, 2020 •

edited

Loading