[Logs UI] Add "View in machine learning" links in the anomaly explorer #74555

afgomez · 2020-08-06T15:56:31Z

Summary

Add links to view the Ml jobs for the anomaly explorer in the Machine learning app.

Follow-up:

The current link is hardcoded. The ML team is working on a URL generator that will make easier for consumers to use URLs to their app.

elasticmachine · 2020-08-06T15:56:33Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

afgomez · 2020-08-10T09:01:30Z

@elasticmachine merge upstream

weltenwort

👀 Reviewing on behalf of @elastic/logs-metrics-ui...

weltenwort

The machine learning team just improved the job management page such that it is possible to link to a filtered state in #74533. What do you think of having these buttons link to the job management page instead, since the flyout is all about managing the jobs and not about the results?

weltenwort · 2020-08-11T10:09:13Z

x-pack/plugins/infra/public/components/logging/log_analysis_results/analyze_in_ml_button.tsx

@@ -11,10 +11,12 @@ import { encode } from 'rison-node';
 import { TimeRange } from '../../../../common/http_api/shared/time_range';
 import { useLinkProps, LinkDescriptor } from '../../../hooks/use_link_props';

+type DatemathRange = TimeRange | { startTime: string; endTime: string };


Would it be worth limiting ourselves to one date representation for simplicity's sake?

I'm removing this, since the time range is not needed for the job management pages

...plugins/infra/public/components/logging/log_analysis_setup/setup_flyout/module_list_card.tsx

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>

afgomez · 2020-08-11T13:02:05Z

What do you think of having these buttons link to the job management page instead?

I think it might make sense... but if I understood #72402 correctly we have to restore the link to the anomaly explorer, right? Do we want to get rid of it?

weltenwort · 2020-08-11T14:27:30Z

Hm, the main use of this link is to allow for the user to manage (stop, edit, delete) the job. So the intended use is different from the link for individual anomalies, which is about inspecting the anomalies.

I probably should have proposed a different URL in the issue. 🤔

This reverts commit 9e339c5.

weltenwort

LGTM, I just left two question below.

weltenwort · 2020-08-19T13:11:15Z

...plugins/infra/public/components/logging/log_analysis_setup/setup_flyout/module_list_card.tsx

  const moduleIcon =
    moduleStatus.type === 'required' ? (
      <EuiIcon size="xxl" type="machineLearningApp" />
    ) : (
      <EuiIcon color="secondary" size="xxl" type="check" />
    );

+  const viewInMlLinkProps = useLinkProps({
+    app: 'ml',
+    hash: '/jobs',


Should we use pathname instead of hash because this seems to be rewritten to /apps/ml/jobs immediately?

Let me try 👍

weltenwort · 2020-08-19T13:12:40Z

...plugins/infra/public/components/logging/log_analysis_setup/setup_flyout/module_list_card.tsx

+        <EuiButtonEmpty {...viewInMlLinkProps}>
+          <FormattedMessage
+            id="xpack.infra.logs.analysis.viewInMlButtonLabel"
+            defaultMessage="View in Machine Learning"
+          />
+        </EuiButtonEmpty>
+      </>


The vertical rhythm is a bit weird. Do we want to insert a <EuiSpacer size="xs" /> above it like shown in the EUI card docs?

I can add it. I could not find the documentation that you mentioned though :/

I was referring to the double-row example code on the <EuiCard> documentation page:

<EuiCard icon={<EuiIcon size="xxl" type="savedObjectsApp" />} title="Save Objects" description="Example of a short card description." footer={ <div> <EuiButton aria-label="Go to Save Objects">Go for it</EuiButton> <EuiSpacer size="xs" /> <EuiText size="s"> <p> Or try <EuiLink href="http://google.com">this</EuiLink> </p> </EuiText> </div> } />

kibanamachine · 2020-08-19T15:52:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ef0a007

Build metrics

async chunks size

id	value	diff	baseline
infra	3.5MB	+904.0B	3.5MB

History

💚 Build #68740 succeeded d6a9a72
💚 Build #67486 succeeded 007e8c0
💚 Build #67182 succeeded 73962ef
💚 Build #67100 succeeded 245bc8b
💔 Build #66967 failed 9e339c5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (30 commits) [code coverage] always download node before team assignment (elastic#75424) [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302) [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555) skip flaky suite (elastic#75440) skip flaky suite (elastic#75386) [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172) [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138) MOAR RAM (elastic#75423) [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315) [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499) [ML] Inference models management (elastic#74978) [Monitoring] Migrate karma tests (elastic#75301) [Index template] Add filters to simulate preview (elastic#74497) Bump and consolidate dependencies (elastic#75360) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) ...

…xplorer (#74555) (#75454) Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

afgomez added 2 commits August 6, 2020 15:41

Add "view in machine learning" buttons to setup flyout

80859ff

Pass time range to ML links

9e339c5

afgomez added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 6, 2020

afgomez added this to the Logs UI 7.10 milestone Aug 6, 2020

afgomez requested a review from a team as a code owner August 6, 2020 15:56

Fix typing

245bc8b

Merge branch 'master' into 72402-manage-jobs-links

73962ef

weltenwort reviewed Aug 11, 2020

View reviewed changes

Fix typo in translation label

007e8c0

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>

afgomez mentioned this pull request Aug 12, 2020

[Logs UI] Anomalies tab doesn't show links to manage jobs in the ML UI unless anomalies are found #72402

Closed

afgomez added 3 commits August 18, 2020 12:49

Merge branch 'master' into 72402-manage-jobs-links

2d8c52b

Revert "Pass time range to ML links"

ec9f024

This reverts commit 9e339c5.

Link to the jobs management pages

d6a9a72

weltenwort approved these changes Aug 19, 2020

View reviewed changes

afgomez added 3 commits August 19, 2020 15:50

Use pathname for the link instead of hash

85e2989

Tweak vertical spacing

99ce32a

Merge branch 'master' into 72402-manage-jobs-links

ef0a007

afgomez merged commit 9611862 into elastic:master Aug 19, 2020

afgomez deleted the 72402-manage-jobs-links branch August 19, 2020 16:07

afgomez mentioned this pull request Aug 19, 2020

[7.x] [Logs UI] Add "View in machine learning" links in the anomaly explorer (#74555) #75454

Merged

qn895 mentioned this pull request Aug 26, 2020

[ML] Extend MlUrlGenerator to support other ML pages #75696

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs UI] Add "View in machine learning" links in the anomaly explorer #74555

[Logs UI] Add "View in machine learning" links in the anomaly explorer #74555

afgomez commented Aug 6, 2020 •

edited

Loading

elasticmachine commented Aug 6, 2020

afgomez commented Aug 10, 2020

weltenwort left a comment

weltenwort left a comment

weltenwort Aug 11, 2020

afgomez Aug 18, 2020

afgomez commented Aug 11, 2020

weltenwort commented Aug 11, 2020

weltenwort left a comment

weltenwort Aug 19, 2020 •

edited

Loading

afgomez Aug 19, 2020

weltenwort Aug 19, 2020

afgomez Aug 19, 2020

weltenwort Aug 20, 2020 •

edited

Loading

kibanamachine commented Aug 19, 2020

[Logs UI] Add "View in machine learning" links in the anomaly explorer #74555

[Logs UI] Add "View in machine learning" links in the anomaly explorer #74555

Conversation

afgomez commented Aug 6, 2020 • edited Loading

Summary

Follow-up:

elasticmachine commented Aug 6, 2020

afgomez commented Aug 10, 2020

weltenwort left a comment

Choose a reason for hiding this comment

weltenwort left a comment

Choose a reason for hiding this comment

weltenwort Aug 11, 2020

Choose a reason for hiding this comment

afgomez Aug 18, 2020

Choose a reason for hiding this comment

afgomez commented Aug 11, 2020

weltenwort commented Aug 11, 2020

weltenwort left a comment

Choose a reason for hiding this comment

weltenwort Aug 19, 2020 • edited Loading

Choose a reason for hiding this comment

afgomez Aug 19, 2020

Choose a reason for hiding this comment

weltenwort Aug 19, 2020

Choose a reason for hiding this comment

afgomez Aug 19, 2020

Choose a reason for hiding this comment

weltenwort Aug 20, 2020 • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Aug 19, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

afgomez commented Aug 6, 2020 •

edited

Loading

weltenwort Aug 19, 2020 •

edited

Loading

weltenwort Aug 20, 2020 •

edited

Loading