Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Pipelines] Processor forms for processors E-J #75046

Closed
wants to merge 30 commits into from
Closed

[Ingest Pipelines] Processor forms for processors E-J #75046

wants to merge 30 commits into from

Conversation

jloleysens
Copy link
Contributor

Summary

This contribution adds forms for the following processors:

  • Enrich
  • Fail
  • Foreach
  • GeoIP
  • Grok
  • Gsub
  • HTML strip
  • Inference
  • Join
  • JSON

How to test

  1. Start Kibana with basic license
  2. Go to ingest pipelines plugin in management section
  3. Add a processor for each of the forms listed above (attempt to submit to see which fields are required)
  4. Create the pipeline

Additional Context

Continuation of #72849

Checklist

Delete any items that are not applicable to this PR.

jloleysens and others added 30 commits July 20, 2020 18:07
@jloleysens
First few processors of the first batch
e120f03 
- Also refactored options to live in scoped objects to avoid
  overriding type (important fix!)
- Have not polished copy or form layout.
@jloleysens
add type to shared imports
71274a3
@jloleysens
Refactors for repeated fields and added forms
1621eb8 
- date_index_name
- dissect
- dot_expander
- drop

Fields refactored:

- Field
- Ignore missing
@elasticmachine
Merge branch 'master' into ingest-pipelines/processor-forms-a-d
9691f9e
@elasticmachine
Merge branch 'master' into ingest-pipelines/processor-forms-a-d
0dad23e
@elasticmachine
Merge branch 'master' into ingest-pipelines/processor-forms-a-d
9952f9b
@elasticmachine
Merge branch 'master' into ingest-pipelines/processor-forms-a-d
1a52d64
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-pipeli…
97eea65 
…nes/processor-forms-a-d

* 'master' of github.com:elastic/kibana: (26 commits)
  [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664)
  [ILM] Convert node details flyout to TS (elastic#73707)
  [Ingest Node Pipelines] Sentence-case processor names (elastic#74645)
  Bump angular dependency from 1.7.9 to 1.8.0 (elastic#74482)
  [ML] Fixing schema for custom rule conditions (elastic#74676)
  [ML] Refactor in preparation for new es client (elastic#74552)
  [ML] Adding initial file analysis overrides (elastic#74376)
  Allow any hostname for chromium proxy bypass (elastic#74693)
  [ML] ML on Kibana Management: Add ability to pass a group ID filter to job management page (elastic#74533)
  [Metrics UI] Fix No Data preview pluralization (elastic#74399)
  [Bug][Security_Solution][Telemetry] Capitalize S in macOS (elastic#74688)
  Remove karma tests  from legacy maps (elastic#74668)
  [Ingest Manager] stop creating events-* index pattern and placeholder index (elastic#74683)
  [Enterprise Search] Update the browser/document title on plugin navigation (elastic#74392)
  [visualizations] Add i18n translation for 'No results found' (elastic#74619)
  [maps] convert vector style properties to TS (elastic#74553)
  bump geckodriver binary to 0.27 (elastic#74638)
  fix: update apm agents to catch abort requests (elastic#74658)
  [Security Solution] Resolver children pagination (elastic#74603)
  add memoryStatus to df analytics page and analytics table in management (elastic#74570)
  ...
@jloleysens
Fix broken imports and some other small refactors
8160f85
@jloleysens
added text editor field and updated pattern and if fields
0bcd67a
@jloleysens
Large copy improvements and updates and other small refactors
1555486 
- Added help text for all fields
- Updated layout so that required fields are always on first
- Replaced circle radio group with a select drop down
@jloleysens
update circle shape type field to select
7059261
@jloleysens
Added "long" option for convert type
a529e38
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-pipeli…
bbbe9d2 
…nes/processor-forms-a-d

* 'master' of github.com:elastic/kibana: (25 commits)
  [ML] Removing full lodash library imports (elastic#74742)
  [Search] Server strategy example (elastic#71679)
  [Reporting] Fix and test for Listing of Reports (elastic#74453)
  [maps] fix drawing shapes (elastic#74689)
  [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601)
  Deprecate schema-less specs in Vega (elastic#73805)
  [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287)
  Timelion deprecation doc (elastic#74508)
  [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736)
  [Lens] Add styling options for x and y axes on the settings popover (elastic#71829)
  [Maps] add initial location option that fits to data bounds (elastic#74583)
  theme function (elastic#73451)
  [data.ui.query] Write filters to query log from default editor. (elastic#74474)
  [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607)
  [Canvas][tech-debt] Convert renderers (elastic#74134)
  [security solutions][lists] Adds end to end tests (elastic#74473)
  pluralized for occurrences vs occurrence (elastic#74564)
  Update links that pointed to CONTRIBUTING.md (elastic#74757)
  [Ingest pipelines] Implement tabs in processor flyout (elastic#74469)
  [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/field_components/text_editor.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/append.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/bytes.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/circle.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/field_name_field.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/ignore_missing_field.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/convert.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/csv.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date_index_name.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dot_expander.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/drop.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/index.ts
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/shared.ts
@jloleysens
fix path import
106701f
@jloleysens
fix types and i18n
5ff03ea
@jloleysens
add validation for dot expander fix append value to be a combobox
acc54d7
@elasticmachine
Merge branch 'master' into ingest-pipelines/processor-forms-a-d
023543b
@jloleysens
Added the enrich processor form (big one)
b1a970e
@jloleysens
added fail processor form
afe633f
@jloleysens
Added foreach processor form
f94c045
@jloleysens
Added geoip processor form and refactored some deserialization
9e83a95
@jloleysens
added grok processor form and updated comments and some i18n ids
960747c
@jloleysens
updated existing gsub processor form to be in line with other forms
5c40bf8
@jloleysens
added html_strip processor form
3f3c45f
@jloleysens
refactored some serialize and deserialize functions and added inferen…
2fa58df 
…ce processor form
@jloleysens
fix copy-pasta mistake in inference form and add join processor form
4e2b33b
@jloleysens
Added JSON processor field
9933916 
- Also factored out target_field field to common field (still have
  to update the all instances)
- Built out special logic for handling add_to_root and
  target_field combo on JSON processor form
- Created another serializer, for default boolean -> undefined.
@jloleysens
remove unused variable
daed879
@jloleysens
Refactor to use new shared target_field component, and fix JSON seria…
0daae40 
…lizer bug
@jloleysens jloleysens added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Feature:Ingest Node Pipelines Ingest node pipelines management labels Aug 14, 2020
@jloleysens jloleysens requested a review from a team as a code owner August 14, 2020 14:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 14, 2020 •
edited
Loading

💔 Build Failed

Failed CI Steps

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
ingestPipelines 401 +26 375

async chunks size

id value diff baseline
ingestPipelines 674.4KB +64.4KB 610.0KB

page load bundle size

id value diff baseline
ingestPipelines 32.7KB +489.0B 32.2KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

Closing, will re-open with clean branch

@jloleysens jloleysens closed this Aug 14, 2020
@alisonelizabeth alisonelizabeth mentioned this pull request Sep 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth Awaiting requested review from alisonelizabeth

Assignees
No one assigned
Labels
Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jloleysens @elasticmachine @kibanamachine