Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Convert our public_url route to config_data and collect initialAppData #75616

Merged
merged 10 commits into from
Aug 21, 2020
Merged

[Enterprise Search] Convert our public_url route to config_data and collect initialAppData #75616

merged 10 commits into from
Aug 21, 2020

Commits on Aug 20, 2020

  1. [Setup] DRY out stripTrailingSlash helper 

    - DRYs out repeated code
- This will be used by an upcoming server/ endpoint change, hence why it's in common
    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    6ff2100 View commit details
    Browse the repository at this point in the history

  2. [Setup] DRY out initial app data types to common/types 

    - In preparation for upcoming server logic that will need to reuse these types
+ DRY out and clean up workplace_search types
  - remove unused supportEligible
  - remove currentUser - unneeded in Kibana
    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    f784009 View commit details
    Browse the repository at this point in the history

  3. Update callEnterpriseSearchConfigAPI to parse and fetch new expected … 

    …data
    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7081be9 View commit details
    Browse the repository at this point in the history

  4. Remove /public_url API for /config_data

    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    181890b View commit details
    Browse the repository at this point in the history

  5. Remove getPublicUrl in favor of directly calling the new /config_data… 

    … API from public/plugin

+ set returned initialData in this.data
    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7cd2140 View commit details
    Browse the repository at this point in the history

  6. Set up product apps to be passed initial data as props

    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    4c836ac View commit details
    Browse the repository at this point in the history

  7. Fix for Kea/redux state not resetting between AS<->WS nav 

    - resetContext at the top level only gets called once total on first plugin load and never after, causing navigating between WS and AS to crash when both have Kea - this fixes the issue

- moves redux Provider to top level app as well
    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    2b55b78 View commit details
    Browse the repository at this point in the history

  8. Add very basic Kea logic file to App Search

    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    1f77660 View commit details
    Browse the repository at this point in the history

  9. Finish AppSearchConfigured tests & set up kea+useEffect mocks

    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    46990ef View commit details
    Browse the repository at this point in the history

  10. [Cleanup] DRY out repeated mock initialAppData to a reusable defaults… 

    … constant
    @cee-chen
    cee-chen committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    f4d815e View commit details
    Browse the repository at this point in the history