[Security Solution] Refactor Network TLS to use Search Strategy #76241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
reviewed
Aug 31, 2020
| desc = 'desc', | ||
| } | ||
|
|
||
| export interface TlsSortField { |
There was a problem hiding this comment.
I think that I would like us to refactor SortField to be like that below. Therefore, now we can have a generic/strict type if need it and TlsSortField can be replaced by SortField<TlsFields>.
Does that make sense?
export interface SortField<Field = string> {
field: Field;
direction: Direction;
}
XavierM
reviewed
Aug 31, 2020
| }; | ||
| }; | ||
| useEffect(() => { | ||
| if (skip) { |
There was a problem hiding this comment.
I am wondering if I made a mistake with allHosts query because I remove the skip. are we really using this skip attributes?
There was a problem hiding this comment.
thanks for fixing my mistake in #76252
…-tls-search-strategy # Conflicts: # x-pack/plugins/security_solution/common/search_strategy/security_solution/hosts/index.ts # x-pack/plugins/security_solution/common/search_strategy/security_solution/index.ts
XavierM
approved these changes
Aug 31, 2020
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Aug 31, 2020
|
Pinging @elastic/siem (Team:SIEM) |
patrykkopycinski
added a commit
that referenced
this pull request
Sep 1, 2020
This was referenced Sep 23, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist