Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Add input revision to the config send to the agent #76327

Merged
merged 4 commits into from
Sep 3, 2020
Merged

[Ingest Manager] Add input revision to the config send to the agent #76327

merged 4 commits into from
Sep 3, 2020

Conversation

nchaulet
Copy link
Member

Summary

Add input revision to the config we send to elastic agent.

@kevinlog @blakerouse can you confirm it's what is needed to get the input revision to endpoint?

Example
Screen Shot 2020-08-31 at 3 54 54 PM

@nchaulet nchaulet added v8.0.0 v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta2 labels Aug 31, 2020
@nchaulet nchaulet requested a review from a team August 31, 2020 19:55
@nchaulet nchaulet self-assigned this Aug 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Aug 31, 2020
@kevinlog
Copy link
Contributor

@nchaulet this looks good. I just tried it out and I saw that the revision does make its way down to the Endpoint.

Here I can see both the Agent policy revision and the Integration policy revision.
image

Right now, I think we should leave the top level Agent Policy revision. I'm apprehensive to take data away from the Endpoint. I think it's OK that the Endpoint still gets an updated policy the Agent updates.

What are your thoughts @ph @blakerouse @ferullo @paul-tavares ?

@nchaulet nchaulet requested review from a team as code owners September 1, 2020 04:08
@blakerouse
Copy link

@kevinlog I think we should take it away, once this is landed and in 7.x. Endpoint will then only get an updated config when that revision changes.

Don't worry it will also get changes if the output or fleet information also changes.

@ferullo
Copy link
Contributor

ferullo commented Sep 1, 2020

If the top-level revision is taken away 7.9 Endpoint's will return Policy failure responses to Kibana. Policy will apply fine, but since the revision is a required field Policy will be "red".

@ph
Copy link
Contributor

ph commented Sep 1, 2020

@ferullo I think we can remove it in 7.10?

@ph
Copy link
Contributor

ph commented Sep 1, 2020

@kevinlog @ferullo @blakerouse I think we can keep the global revision and still send it down, endpoint could use the revision in the input instead. Keeping it global would probably help with debugging when an option changes outside of the "input" that revision would still be incremented.

@nchaulet
Copy link
Member Author

nchaulet commented Sep 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
ingestManager 468.1KB +32.0B 468.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit da8ccd7 into elastic:master Sep 3, 2020
@nchaulet nchaulet deleted the feature-agent-config-add-input-revision branch September 3, 2020 15:21
nchaulet added a commit to nchaulet/kibana that referenced this pull request Sep 3, 2020
@nchaulet
[Ingest Manager] Add input revision to the config send to the agent (e…
585577f 
…lastic#76327)
@nchaulet nchaulet mentioned this pull request Sep 3, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 3, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
c564990 
* master: (340 commits)
  [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943)
  [release notes] automatically retry on Github API 5xx errors (elastic#76447)
  [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392)
  [i18n] Integrate 7.9.1 Translations (elastic#76391)
  [APM] Update aggregations to support script sources (elastic#76429)
  [Security Solution] Refactor Network Top Countries to use Search Strategy (elastic#76244)
  Document security settings available on ESS (elastic#76513)
  [Ingest Manager] Add input revision to the config send to the agent (elastic#76327)
  [DOCS] Identifies cloud settings for Monitoring (elastic#76579)
  [DOCS] Identifies Cloud settings in Dev Tools (elastic#76583)
  [Ingest Manager] Better default value for fleet long polling timeout (elastic#76393)
  [data.indexPatterns] Fix broken rollup index pattern creation (elastic#76593)
  [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558)
  [Security Solution] add an excess validation instead of the exact match (elastic#76472)
  Introduce TS incremental builds & move src/test_utils to TS project  (elastic#76082)
  fix bad merge (elastic#76629)
  [Newsfeed] Ensure the version format when calling the API (elastic#76381)
  remove server_extensions mixin (elastic#76606)
  Remove legacy applications and legacy mode (elastic#75987)
  [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749)
  ...
nchaulet added a commit that referenced this pull request Sep 3, 2020
@nchaulet
[Ingest Manager] Add input revision to the config send to the agent (#…
a2c5fc2 
…76327) (#76648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

@jen-huang jen-huang Awaiting requested review from jen-huang

Assignees

@nchaulet nchaulet

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nchaulet @elasticmachine @kevinlog @blakerouse @ferullo @ph @kibanamachine