Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy #76409

Merged
merged 16 commits into from
Sep 7, 2020
Merged

[Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy #76409

merged 16 commits into from
Sep 7, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Sep 1, 2020 •
edited
Loading

Summary

image

Checklist

@patrykkopycinski patrykkopycinski self-assigned this Sep 1, 2020
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into hosts-overvie…
8fb63ff 
…w-search-strategy
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into hosts-overvie…
55009e5 
…w-search-strategy
@patrykkopycinski
fix i18n
1d15571
@patrykkopycinski
Fix import
80123ec
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into hosts-overvie…
622a340 
…w-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/hosts/index.ts
#	x-pack/plugins/security_solution/public/hosts/containers/hosts/details/_index.tsx
@patrykkopycinski patrykkopycinski marked this pull request as ready for review September 2, 2020 15:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into hosts-overvie…
438a7eb 
…w-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/hosts/overview/index.ts
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into hosts-overvie…
cc43bcd 
…w-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/hosts/index.ts
#	x-pack/plugins/security_solution/server/search_strategy/security_solution/factory/hosts/details/query.host_details.dsl.ts
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into hosts-overvie…
a68371b 
…w-search-strategy
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/host-ove…
ef122ee 
…rview-search-strategy

# Conflicts:
#	x-pack/plugins/security_solution/common/search_strategy/security_solution/hosts/index.ts
@patrykkopycinski
refactor OverviewNetwork
a104409
@patrykkopycinski patrykkopycinski changed the title [Security Solution] Refactor OverviewHost to use Search Strategy [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy Sep 5, 2020
angorayc
angorayc reviewed Sep 7, 2020
View reviewed changes
...ns/security_solution/server/search_strategy/security_solution/factory/hosts/details/index.ts
const aggregations: HostAggEsItem = get('aggregations', response.rawResponse) || {};
const inspect = {
dsl: [inspectStringifyObject(buildHostDetailsQuery(options))],
response: [inspectStringifyObject(response)],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider remove response from inspect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to do in the next PR that where I will take care of the host details page

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1962 +2 1960

async chunks size

id value diff baseline
securitySolution 9.9MB +15.2KB 9.9MB

distributable file count

id value diff baseline
default 45442 +7 45435

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 219d0b5 into elastic:master Sep 7, 2020
@patrykkopycinski patrykkopycinski deleted the hosts-overview-search-strategy branch September 7, 2020 16:57
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 7, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Sep 7, 2020
@patrykkopycinski
[Security Solution] Refactor OverviewHost and OverviewNetwork to use …
90f7d7d 
…Search Strategy (elastic#76409)
patrykkopycinski added a commit that referenced this pull request Sep 7, 2020
@patrykkopycinski
[Security Solution] Refactor OverviewHost and OverviewNetwork to use …
87d1d55 
…Search Strategy (#76409) (#76895)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2020
@jloleysens
Merge branch 'ilm/fix/pre-existing-policy-with-no-existing-repository…
1a85d85 
…' of github.com:jloleysens/kibana into ilm/fix/pre-existing-policy-with-no-existing-repository

* 'ilm/fix/pre-existing-policy-with-no-existing-repository' of github.com:jloleysens/kibana:
  fix empty string in selected indices (elastic#76855)
  [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy (elastic#76409)
  Use Search API in Timelion (sync) (elastic#75115)
  [telemetry] expose getIsOptedIn function in plugin start contract (elastic#75143)
  [ILM] Clean up remaining js files and any typings (elastic#76803)
  [Logs UI] Shared `<LogStream />` component (elastic#76262)
  [Security Solution] Add unit test for all hosts (elastic#76752)
  [Security Solution] Add unit test for authentications search strategy (elastic#76665)
  Do not apply search source data for tsvb (elastic#75137)
  [Security Solution] Refactor NetworkDns to use Search Strategy (elastic#76250)
  [SECURITY SOLUTION] Adds 'cypress:open-as-ci' command (elastic#76125)
  [Logs UI] Update alert executor tests (elastic#75764)
  [Functional] Unskip vega tests and fix flakiness (elastic#76600)
  [Data] Query String Input accepts classname prop (elastic#76848)
  [ML] Swim lane pagination for viewing by job id (elastic#76847)
  [Security Solution] Refactor MatrixHistogram to use Search Strategy (elastic#76603)
  [APM] Use the outcome field to calculate the transaction error rate chart (elastic#75528)
  [APM] Use observer.hostname instead of observer.name (elastic#76074)
  Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/data-tier…
8b1f1dd 
…s-for-710

* 'master' of github.com:elastic/kibana:
  [Search] Use async es client endpoints (elastic#76872)
  fix empty string in selected indices (elastic#76855)
  [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy (elastic#76409)
  Use Search API in Timelion (sync) (elastic#75115)
  [telemetry] expose getIsOptedIn function in plugin start contract (elastic#75143)
  [ILM] Clean up remaining js files and any typings (elastic#76803)
  [Logs UI] Shared `<LogStream />` component (elastic#76262)
  [Security Solution] Add unit test for all hosts (elastic#76752)
  [Security Solution] Add unit test for authentications search strategy (elastic#76665)
  Do not apply search source data for tsvb (elastic#75137)
  [Security Solution] Refactor NetworkDns to use Search Strategy (elastic#76250)
  [SECURITY SOLUTION] Adds 'cypress:open-as-ci' command (elastic#76125)
  [Logs UI] Update alert executor tests (elastic#75764)
  [Functional] Unskip vega tests and fix flakiness (elastic#76600)
  [Data] Query String Input accepts classname prop (elastic#76848)
  [ML] Swim lane pagination for viewing by job id (elastic#76847)
  [Security Solution] Refactor MatrixHistogram to use Search Strategy (elastic#76603)
  [APM] Use the outcome field to calculate the transaction error rate chart (elastic#75528)
  [APM] Use observer.hostname instead of observer.name (elastic#76074)
  Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.tsx
#	x-pack/plugins/index_lifecycle_management/common/types/index.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/services/api.ts
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 23, 2020
Merged
1 task
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @angorayc @MindyRS