Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip checking for the reserved realm #76687

Merged
merged 5 commits into from
Sep 9, 2020
Merged

Skip checking for the reserved realm #76687

merged 5 commits into from
Sep 9, 2020

Conversation

legrego
Copy link
Member

@legrego legrego commented Sep 3, 2020 •
edited
Loading

Summary

Updates the authentication tests to not assume the reserved realm will be available. This realm is disabled for ESS installations, and therefore only available on-prem.

Resolves #76165

@legrego
Copy link
Member Author

legrego commented Sep 8, 2020

@liza-mae I know we have the flaky test runner to verify failing tests against Cloud, but is there a way for me to run the entire test suite against Cloud? I have fixes scattered around many FTR configurations, and if I understand the flaky runner correctly, it isn't capable of running more than one configuration at a time.

@liza-mae
Copy link
Contributor

liza-mae commented Sep 8, 2020

@legrego correct the flaky test runner does not support running all the test suites, it is broken down by configuration. The options you have to test everything are 1) setup a cluster manually and then run your test changes locally with all tests enabled or merge your changes and it will be picked up by the main cloud job that runs them all. Thanks.

@legrego
Copy link
Member Author

legrego commented Sep 9, 2020 •
edited
Loading

Cloud CI Runs:

^ These suites aren't capable of running in isolation using the flake test runner, so we will take Liza's second suggestion and merge to verify this works as expected.

@legrego legrego added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.2 v8.0.0 Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! and removed v7.9.2 labels Sep 9, 2020
@legrego legrego marked this pull request as ready for review September 9, 2020 18:24
@legrego legrego requested a review from a team as a code owner September 9, 2020 18:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego
Copy link
Member Author

legrego commented Sep 9, 2020

@elasticmachine merge upstream

@jportner
Copy link
Contributor

jportner commented Sep 9, 2020

Perhaps we should add comments to each of the files where you removed the check for authentication_realm, so we don't try adding it again in the future? 😬

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jportner
jportner approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legrego legrego merged commit 2965f3e into elastic:master Sep 9, 2020
@legrego legrego deleted the security/auth-tests-ess-failure branch September 9, 2020 23:48
@legrego legrego mentioned this pull request Sep 9, 2020
Merged
legrego added a commit that referenced this pull request Sep 10, 2020
@legrego @elasticmachine
Skip checking for the reserved realm (#76687) (#77126)
82ec803 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 10, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
2940bb2 
* master: (25 commits)
  [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
  clean up test (elastic#76887)
  [Enterprise Search] Update shared API request handler (elastic#77112)
  [Maps] convert ESAggSource to TS (elastic#76999)
  Add plugin status API - take 2 (elastic#76732)
  Adds lens as a readable saved object for read-only dashboard users (elastic#77067)
  Skip checking for the reserved realm (elastic#76687)
  Reporting/diagnostics (elastic#74314)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  [ML] Add decision path charts to exploration results table (elastic#73561)
  Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016)
  [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 10, 2020
@gmmorris
Merge branch 'master' into alerts/improve-find-pref
9d86fcd 
* master: (41 commits)
  [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
  clean up test (elastic#76887)
  [Enterprise Search] Update shared API request handler (elastic#77112)
  [Maps] convert ESAggSource to TS (elastic#76999)
  Add plugin status API - take 2 (elastic#76732)
  Adds lens as a readable saved object for read-only dashboard users (elastic#77067)
  Skip checking for the reserved realm (elastic#76687)
  Reporting/diagnostics (elastic#74314)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  [ML] Add decision path charts to exploration results table (elastic#73561)
  Bump eventemitter3 from 4.0.0 to 4.0.7 (elastic#77016)
  [Ingest Pipelines] Add descriptions for ingest processors K-S (elastic#76981)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 10, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
e4489fe 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (39 commits)
  [APM] Always load esarchives from common (elastic#77139)
  [Ingest Manager] Handle Legacy ES client errors (elastic#76865)
  [Docs] URL Drilldown (elastic#76529)
  [bugfix] Replace panel flyout opens 2 flyouts (elastic#76931)
  clean up test (elastic#76887)
  [Enterprise Search] Update shared API request handler (elastic#77112)
  [Maps] convert ESAggSource to TS (elastic#76999)
  Add plugin status API - take 2 (elastic#76732)
  Adds lens as a readable saved object for read-only dashboard users (elastic#77067)
  Skip checking for the reserved realm (elastic#76687)
  Reporting/diagnostics (elastic#74314)
  Reporting/Test: unskip non-screenshot tests (elastic#77088)
  Move metrics to setup and add cgroup metrics (elastic#76730)
  [Enterprise Search] Add Overview landing page/plugin (elastic#76734)
  First pass. Change TS type. Update OpenAPI (elastic#76434)
  [CI] Balance xpack ci groups a bit (elastic#77068)
  [Security_solution][Detections] Refactor signal ancestry to allow multiple parents (elastic#76531)
  [Maps] convert MetricsEditor to TS (elastic#76727)
  IndexMigrator: fix non blocking migration wrapper promise rejection (elastic#77018)
  [Enterprise Search] Update config data endpoint to v2 (elastic#76970)
  ...

# Conflicts:
#	src/plugins/es_ui_shared/static/forms/hook_form_lib/components/use_array.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@legrego @liza-mae @elasticmachine @jportner @kibanamachine