Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Update shared API request handler #77112

Merged
merged 3 commits into from
Sep 10, 2020
Merged

[Enterprise Search] Update shared API request handler #77112

merged 3 commits into from
Sep 10, 2020

Commits on Sep 9, 2020

  1. Add user auth check for /ent/select redirects 

    - Recent Enterprise Search CSRF changes have made it so redirects can occur to /ent/select and not just /login
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    e6bb08c View commit details
    Browse the repository at this point in the history

  2. Fix request.query typing 

    - API endpoints passing in custom request.query params were seeing {} type errors - this change works around them
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    5b84f79 View commit details
    Browse the repository at this point in the history

  3. Add Accept and Content-Type JSON headers to Enterprise Search requests 

    - Without the Accept header, Enterprise Search APIs will kick back a CSRF error
- Without the Content-Type header, APIs will not load JSON bodies as parameters per Ruby on Rails docs
    @cee-chen
    cee-chen committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    a21f5d5 View commit details
    Browse the repository at this point in the history