Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Pipelines] Add descriptions for ingest processors T-U #77497

Merged
merged 4 commits into from
Sep 16, 2020
Merged

[Ingest Pipelines] Add descriptions for ingest processors T-U #77497

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4227984
[Ingest Pipelines] Add descriptions for ingest processors T-U
jrodewig Sep 15, 2020
d536fec
Fix il8n IDs
jrodewig Sep 15, 2020
99bf9d0
Merge remote-tracking branch 'upstream/master' into es_ui-t-u-process…
jrodewig Sep 16, 2020
70fc6cb
Merge remote-tracking branch 'upstream/master' into es_ui-t-u-process…
jrodewig Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...omponents/pipeline_processors_editor/components/manage_processor_form/processors/trim.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const Trim: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.trimForm.fieldNameHelpText',
{ defaultMessage: 'The field to trim whitespace from.' }
{ defaultMessage: 'Field to trim. For an array of strings, each element is trimmed.' }
)}
/>

Expand Down
5 changes: 4 additions & 1 deletion ...ents/pipeline_processors_editor/components/manage_processor_form/processors/uppercase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ export const Uppercase: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.uppercaseForm.fieldNameHelpText',
{ defaultMessage: 'The field to make uppercase.' }
{
defaultMessage:
'Field to uppercase. For an array of strings, each element is uppercased.',
}
)}
/>

Expand Down
2 changes: 1 addition & 1 deletion ...nts/pipeline_processors_editor/components/manage_processor_form/processors/url_decode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const UrlDecode: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.urlDecodeForm.fieldNameHelpText',
{ defaultMessage: 'The field to decode.' }
{ defaultMessage: 'Field to decode. For an array of strings, each element is decoded.' }
)}
/>

Expand Down
18 changes: 15 additions & 3 deletions ...nts/pipeline_processors_editor/components/manage_processor_form/processors/user_agent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
*/

import React, { FunctionComponent } from 'react';
import { EuiCode } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';

import { EuiComboBoxOptionOption } from '@elastic/eui';
Expand Down Expand Up @@ -39,7 +41,7 @@ const fieldsConfig: FieldsConfig = {
'xpack.ingestPipelines.pipelineEditor.userAgentForm.regexFileFieldHelpText',
{
defaultMessage:
'A filename containing the regular expressions for parsing the user agent string.',
'File containing the regular expressions used to parse the user agent string.',
}
),
},
Expand All @@ -51,13 +53,23 @@ export const UserAgent: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.userAgentForm.fieldNameHelpText',
{ defaultMessage: 'The field containing the user agent string.' }
{ defaultMessage: 'Field containing the user agent string.' }
)}
/>

<UseField config={fieldsConfig.regex_file} component={Field} path="fields.regex_file" />

<TargetField />
<TargetField
helpText={
<FormattedMessage
id="xpack.ingestPipelines.pipelineEditor.userAgentForm.targetFieldHelpText"
defaultMessage="Output field. Defaults to {defaultField}."
values={{
defaultField: <EuiCode inline>{'user_agent'}</EuiCode>,
}}
/>
}
/>

<PropertiesField
helpText={i18n.translate(
Expand Down
12 changes: 12 additions & 0 deletions ...on/components/pipeline_processors_editor/components/shared/map_processor_type_to_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,27 +413,39 @@ export const mapProcessorTypeToDescriptor: MapProcessorTypeToDescriptor = {
label: i18n.translate('xpack.ingestPipelines.processors.label.trim', {
defaultMessage: 'Trim',
}),
description: i18n.translate('xpack.ingestPipelines.processors.description.trim', {
defaultMessage: 'Removes leading and trailing whitespace from a string.',
}),
},
uppercase: {
FieldsComponent: Uppercase,
docLinkPath: '/uppercase-processor.html',
label: i18n.translate('xpack.ingestPipelines.processors.label.uppercase', {
defaultMessage: 'Uppercase',
}),
description: i18n.translate('xpack.ingestPipelines.processors.description.uppercase', {
defaultMessage: 'Converts a string to uppercase.',
}),
},
urldecode: {
FieldsComponent: UrlDecode,
docLinkPath: '/urldecode-processor.html',
label: i18n.translate('xpack.ingestPipelines.processors.label.urldecode', {
defaultMessage: 'URL decode',
}),
description: i18n.translate('xpack.ingestPipelines.processors.description.urldecode', {
defaultMessage: 'Decodes a URL-encoded string.',
}),
},
user_agent: {
FieldsComponent: UserAgent,
docLinkPath: '/user-agent-processor.html',
label: i18n.translate('xpack.ingestPipelines.processors.label.userAgent', {
defaultMessage: 'User agent',
}),
description: i18n.translate('xpack.ingestPipelines.processors.description.userAgent', {
defaultMessage: "Extracts values from a browser's user agent string.",
}),
},
};

Expand Down