[Usage Collection] [schema] static_telemetry
#77902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Feature:Telemetry
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry) |
14 tasks
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsdistributable file count
History
To update your PR or re-run it, just comment with: |
| @@ -60,10 +61,12 @@ export function isFileReadable(path: string): boolean { | |||
| * @param configPath The config file path. | |||
| * @returns The unmodified JSON object if the file exists and is a valid YAML file. | |||
| */ | |||
| export async function readTelemetryFile(path: string): Promise<object | undefined> { | |||
There was a problem hiding this comment.
Using configPath rather than path now matches the function description, thanks for making them consistent. We could have gone either way here, either updating the param as is the case here or changing the description.
There was a problem hiding this comment.
Thank you for noticing. I decided on the configPath side because path matches the 'path' library (and I tend to avoid it as a variable when possible).
afharo
added a commit
that referenced
this pull request
Sep 24, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lukeelmers
added
the
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
schemadefinition to the collectorstatic_telemetry.Related to #70180.
For maintainers