Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution] Cleanup Tls graphql (#78265) #78283

Merged

Conversation

patrykkopycinski
Copy link
Contributor

Backports the following commits to 7.x:

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/modules/get_module·ts.apis Machine Learning modules get_module "before all" hook for "lists all modules"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/72381

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:07:37]           └-: Machine Learning
[00:07:37]             └-> "before all" hook
[00:07:37]             └-> "before all" hook
[00:07:37]               │ debg creating role ft_ml_source
[00:07:37]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added role [ft_ml_source]
[00:07:37]               │ debg creating role ft_ml_source_readonly
[00:07:37]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added role [ft_ml_source_readonly]
[00:07:37]               │ debg creating role ft_ml_dest
[00:07:37]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added role [ft_ml_dest]
[00:07:37]               │ debg creating role ft_ml_dest_readonly
[00:07:38]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added role [ft_ml_dest_readonly]
[00:07:38]               │ debg creating role ft_ml_ui_extras
[00:07:38]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added role [ft_ml_ui_extras]
[00:07:38]               │ debg creating role ft_default_space_ml_all
[00:07:38]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added role [ft_default_space_ml_all]
[00:07:38]               │ debg creating role ft_default_space_ml_read
[00:07:38]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added role [ft_default_space_ml_read]
[00:07:38]               │ debg creating role ft_default_space_ml_none
[00:07:38]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added role [ft_default_space_ml_none]
[00:07:38]               │ debg creating user ft_ml_poweruser
[00:07:38]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added user [ft_ml_poweruser]
[00:07:38]               │ debg created user ft_ml_poweruser
[00:07:38]               │ debg creating user ft_ml_poweruser_spaces
[00:07:38]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added user [ft_ml_poweruser_spaces]
[00:07:38]               │ debg created user ft_ml_poweruser_spaces
[00:07:38]               │ debg creating user ft_ml_viewer
[00:07:38]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added user [ft_ml_viewer]
[00:07:38]               │ debg created user ft_ml_viewer
[00:07:38]               │ debg creating user ft_ml_viewer_spaces
[00:07:38]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added user [ft_ml_viewer_spaces]
[00:07:38]               │ debg created user ft_ml_viewer_spaces
[00:07:38]               │ debg creating user ft_ml_unauthorized
[00:07:38]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added user [ft_ml_unauthorized]
[00:07:38]               │ debg created user ft_ml_unauthorized
[00:07:38]               │ debg creating user ft_ml_unauthorized_spaces
[00:07:38]               │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xxl-1600865327103943776] added user [ft_ml_unauthorized_spaces]
[00:07:38]               │ debg created user ft_ml_unauthorized_spaces
[00:07:38]             └-: modules
[00:07:38]               └-> "before all" hook
[00:07:38]               └-: get_module
[00:07:38]                 └-> "before all" hook
[00:07:38]                 └-> "before all" hook
[00:07:38]                   │ debg applying update to kibana config: {"dateFormat:tz":"UTC"}
[00:07:38]                   │ proc [kibana]   log   [13:50:23.771] [error][data][elasticsearch] [version_conflict_engine_exception]: [config:7.10.0-SNAPSHOT]: version conflict, document already exists (current version [1])
[00:07:38]                   └- ✖ fail: apis Machine Learning modules get_module "before all" hook for "lists all modules"
[00:07:38]                   │      Error: Request failed with status code 409
[00:07:38]                   │       at createError (/dev/shm/workspace/kibana/node_modules/axios/lib/core/createError.js:16:15)
[00:07:38]                   │       at settle (/dev/shm/workspace/kibana/node_modules/axios/lib/core/settle.js:17:12)
[00:07:38]                   │       at IncomingMessage.handleStreamEnd (/dev/shm/workspace/kibana/node_modules/axios/lib/adapters/http.js:236:11)
[00:07:38]                   │       at endReadableNT (_stream_readable.js:1145:12)
[00:07:38]                   │       at process._tickCallback (internal/process/next_tick.js:63:19)
[00:07:38]                   │ 
[00:07:38]                   │ 

Stack Trace

{ Error: Request failed with status code 409
    at createError (/dev/shm/workspace/kibana/node_modules/axios/lib/core/createError.js:16:15)
    at settle (/dev/shm/workspace/kibana/node_modules/axios/lib/core/settle.js:17:12)
    at IncomingMessage.handleStreamEnd (/dev/shm/workspace/kibana/node_modules/axios/lib/adapters/http.js:236:11)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
  config:
   { url: 'http://elastic:changeme@localhost:6141/api/kibana/settings',
     method: 'post',
     data: '{"changes":{"dateFormat:tz":"UTC"}}',
     headers:
      { Accept: 'application/json, text/plain, */*',
        'Content-Type': 'application/json;charset=utf-8',
        'kbn-xsrf': 'kbn-client',
        'User-Agent': 'axios/0.19.2',
        'Content-Length': 35 },
     transformRequest: [ [Function: transformRequest] ],
     transformResponse: [ [Function: transformResponse] ],
     timeout: 0,
     adapter: [Function: httpAdapter],
     xsrfCookieName: 'XSRF-TOKEN',
     xsrfHeaderName: 'X-XSRF-TOKEN',
     maxContentLength: -1,
     validateStatus: [Function: validateStatus],
     httpsAgent: null },
  request:
   ClientRequest {
     _events:
      [Object: null prototype] {
        socket: [Function],
        abort: [Function],
        aborted: [Function],
        error: [Function],
        timeout: [Function],
        prefinish: [Function: requestOnPrefinish] },
     _eventsCount: 6,
     _maxListeners: undefined,
     output: [],
     outputEncodings: [],
     outputCallbacks: [],
     outputSize: 0,
     writable: true,
     _last: true,
     chunkedEncoding: false,
     shouldKeepAlive: false,
     useChunkedEncodingByDefault: true,
     sendDate: false,
     _removedConnection: false,
     _removedContLen: false,
     _removedTE: false,
     _contentLength: null,
     _hasBody: true,
     _trailer: '',
     finished: true,
     _headerSent: true,
     socket:
      Socket {
        connecting: false,
        _hadError: false,
        _handle: null,
        _parent: null,
        _host: 'localhost',
        _readableState: [ReadableState],
        readable: false,
        _events: [Object],
        _eventsCount: 6,
        _maxListeners: undefined,
        _writableState: [WritableState],
        writable: false,
        allowHalfOpen: false,
        _sockname: null,
        _pendingData: null,
        _pendingEncoding: '',
        server: null,
        _server: null,
        parser: null,
        _httpMessage: [Circular],
        write: [Function: writeAfterFIN],
        [Symbol(asyncId)]: 3345551,
        [Symbol(lastWriteQueueSize)]: 0,
        [Symbol(timeout)]: null,
        [Symbol(kBytesRead)]: 535,
        [Symbol(kBytesWritten)]: 318 },
     connection:
      Socket {
        connecting: false,
        _hadError: false,
        _handle: null,
        _parent: null,
        _host: 'localhost',
        _readableState: [ReadableState],
        readable: false,
        _events: [Object],
        _eventsCount: 6,
        _maxListeners: undefined,
        _writableState: [WritableState],
        writable: false,
        allowHalfOpen: false,
        _sockname: null,
        _pendingData: null,
        _pendingEncoding: '',
        server: null,
        _server: null,
        parser: null,
        _httpMessage: [Circular],
        write: [Function: writeAfterFIN],
        [Symbol(asyncId)]: 3345551,
        [Symbol(lastWriteQueueSize)]: 0,
        [Symbol(timeout)]: null,
        [Symbol(kBytesRead)]: 535,
        [Symbol(kBytesWritten)]: 318 },
     _header:
      'POST /api/kibana/settings HTTP/1.1\r\nAccept: application/json, text/plain, */*\r\nContent-Type: application/json;charset=utf-8\r\nkbn-xsrf: kbn-client\r\nUser-Agent: axios/0.19.2\r\nContent-Length: 35\r\nHost: localhost:6141\r\nAuthorization: Basic ZWxhc3RpYzpjaGFuZ2VtZQ==\r\nConnection: close\r\n\r\n',
     _onPendingData: [Function: noopPendingOutput],
     agent:
      Agent {
        _events: [Object],
        _eventsCount: 1,
        _maxListeners: undefined,
        defaultPort: 80,
        protocol: 'http:',
        options: [Object],
        requests: {},
        sockets: [Object],
        freeSockets: {},
        keepAliveMsecs: 1000,
        keepAlive: false,
        maxSockets: Infinity,
        maxFreeSockets: 256 },
     socketPath: undefined,
     timeout: undefined,
     method: 'POST',
     insecureHTTPParser: undefined,
     path: '/api/kibana/settings',
     _ended: true,
     res:
      IncomingMessage {
        _readableState: [ReadableState],
        readable: false,
        _events: [Object],
        _eventsCount: 3,
        _maxListeners: undefined,
        socket: [Socket],
        connection: [Socket],
        httpVersionMajor: 1,
        httpVersionMinor: 1,
        httpVersion: '1.1',
        complete: true,
        headers: [Object],
        rawHeaders: [Array],
        trailers: {},
        rawTrailers: [],
        aborted: false,
        upgrade: false,
        url: '',
        method: null,
        statusCode: 409,
        statusMessage: 'Conflict',
        client: [Socket],
        _consuming: false,
        _dumped: false,
        req: [Circular],
        responseUrl: 'http://elastic:changeme@localhost:6141/api/kibana/settings',
        redirects: [] },
     aborted: undefined,
     timeoutCb: null,
     upgradeOrConnect: false,
     parser: null,
     maxHeadersCount: null,
     _redirectable:
      Writable {
        _writableState: [WritableState],
        writable: true,
        _events: [Object],
        _eventsCount: 2,
        _maxListeners: undefined,
        _options: [Object],
        _redirectCount: 0,
        _redirects: [],
        _requestBodyLength: 35,
        _requestBodyBuffers: [],
        _onNativeResponse: [Function],
        _currentRequest: [Circular],
        _currentUrl: 'http://elastic:changeme@localhost:6141/api/kibana/settings' },
     [Symbol(isCorked)]: false,
     [Symbol(outHeadersKey)]:
      [Object: null prototype] {
        accept: [Array],
        'content-type': [Array],
        'kbn-xsrf': [Array],
        'user-agent': [Array],
        'content-length': [Array],
        host: [Array],
        authorization: [Array] } },
  response:
   { status: 409,
     statusText: 'Conflict',
     headers:
      { 'kbn-name': 'kibana-ci-immutable-debian-tests-xxl-1600865327103943776',
        'kbn-license-sig':
         '38c30158a65275a36a230978ed711726272b96f4ff28b572a5385fe4ea1dc00c',
        'content-type': 'application/json; charset=utf-8',
        'cache-control': 'private, no-cache, no-store, must-revalidate',
        'content-length': '174',
        date: 'Wed, 23 Sep 2020 13:50:23 GMT',
        connection: 'close' },
     config:
      { url: 'http://elastic:changeme@localhost:6141/api/kibana/settings',
        method: 'post',
        data: '{"changes":{"dateFormat:tz":"UTC"}}',
        headers: [Object],
        transformRequest: [Array],
        transformResponse: [Array],
        timeout: 0,
        adapter: [Function: httpAdapter],
        xsrfCookieName: 'XSRF-TOKEN',
        xsrfHeaderName: 'X-XSRF-TOKEN',
        maxContentLength: -1,
        validateStatus: [Function: validateStatus],
        httpsAgent: null },
     request:
      ClientRequest {
        _events: [Object],
        _eventsCount: 6,
        _maxListeners: undefined,
        output: [],
        outputEncodings: [],
        outputCallbacks: [],
        outputSize: 0,
        writable: true,
        _last: true,
        chunkedEncoding: false,
        shouldKeepAlive: false,
        useChunkedEncodingByDefault: true,
        sendDate: false,
        _removedConnection: false,
        _removedContLen: false,
        _removedTE: false,
        _contentLength: null,
        _hasBody: true,
        _trailer: '',
        finished: true,
        _headerSent: true,
        socket: [Socket],
        connection: [Socket],
        _header:
         'POST /api/kibana/settings HTTP/1.1\r\nAccept: application/json, text/plain, */*\r\nContent-Type: application/json;charset=utf-8\r\nkbn-xsrf: kbn-client\r\nUser-Agent: axios/0.19.2\r\nContent-Length: 35\r\nHost: localhost:6141\r\nAuthorization: Basic ZWxhc3RpYzpjaGFuZ2VtZQ==\r\nConnection: close\r\n\r\n',
        _onPendingData: [Function: noopPendingOutput],
        agent: [Agent],
        socketPath: undefined,
        timeout: undefined,
        method: 'POST',
        insecureHTTPParser: undefined,
        path: '/api/kibana/settings',
        _ended: true,
        res: [IncomingMessage],
        aborted: undefined,
        timeoutCb: null,
        upgradeOrConnect: false,
        parser: null,
        maxHeadersCount: null,
        _redirectable: [Writable],
        [Symbol(isCorked)]: false,
        [Symbol(outHeadersKey)]: [Object] },
     data:
      { statusCode: 409,
        error: 'Conflict',
        message:
         '[config:7.10.0-SNAPSHOT]: version conflict, document already exists (current version [1]): version_conflict_engine_exception' } },
  isAxiosError: true,
  toJSON: [Function] }

Build metrics

async chunks size

id value diff baseline
securitySolution 10.2MB -4.8KB 10.2MB

page load bundle size

id value diff baseline
securitySolution 793.5KB -161.0B 793.6KB

distributable file count

id value diff baseline
default 47564 -8 47572

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 6aa03b7 into elastic:7.x Sep 23, 2020
@patrykkopycinski patrykkopycinski deleted the backport/7.x/pr-78265 branch September 23, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants