Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Improve page-load axis #78392

Merged
merged 17 commits into from
Oct 1, 2020
Merged

[UX] Improve page-load axis #78392

merged 17 commits into from
Oct 1, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 24, 2020 •
edited
Loading

Summary

image

@shahzad31 shahzad31 self-assigned this Sep 24, 2020
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 labels Sep 24, 2020
@shahzad31 shahzad31 marked this pull request as ready for review September 24, 2020 12:14
@shahzad31 shahzad31 requested a review from a team as a code owner September 24, 2020 12:14
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

justinkambic
justinkambic reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few questions/corrections, but looks good!

x-pack/plugins/apm/public/components/app/RumDashboard/ClientMetrics/index.tsx
numeral(pageViewsTotal).format('0,0')
) : (
<EuiToolTip content={numeral(pageViewsTotal).format('0,0')}>
<>{numeral(pageViewsTotal).format('0 a')}</>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why React.Fragment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EuiTitle goes crazy if simple text is provided as child, it needs element.

x-pack/plugins/apm/server/lib/rum_client/get_page_load_distribution.ts Outdated Show resolved Hide resolved
x-pack/plugins/apm/server/lib/rum_client/get_page_load_distribution.ts
@@ -15,24 +15,38 @@ import {

export const MICRO_TO_SEC = 1000000;

const NUMBER_OF_PLD_STEPS = 100;

export function microToSec(val: number) {
return Math.round((val / MICRO_TO_SEC + Number.EPSILON) * 100) / 100;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just noticing this, but why the usage of Number.EPSILON?

Given that we are using Math.round on the result, is adding Number.EPSILON to val/MICRO_TO_SEC going to have any significant outcome on the output of Math.round? Sorry if I'm missing something, it just seemed strange to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i wanted to two decimal places here without rounding out the values.

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 4.1MB 4.2MB +2.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 07ebb81 into elastic:master Oct 1, 2020
@shahzad31 shahzad31 deleted the improve-page-load-axis branch October 1, 2020 08:16
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Oct 1, 2020
@shahzad31 @elasticmachine
[UX] Improve page-load axis (elastic#78392)
9495ff4 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@shahzad31 shahzad31 mentioned this pull request Oct 1, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 1, 2020
@gmmorris
Merge branch 'master' into actions/preconfigured-connector-error-on-edit
1e99991 
* master: (36 commits)
  [I18n] fix eui tokens (elastic#78951)
  Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768)
  Make the actual Vislib import async (elastic#78949)
  Fix ML conditionals links Cypress tests (elastic#78568)
  [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761)
  [UX] Improve page-load axis (elastic#78392)
  [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610)
  Data plugin README (elastic#78750)
  [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009)
  fixing api test (elastic#78964)
  [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129)
  [Loggers] Rename "telemetry" to "usage" (elastic#78130)
  [Usage Collection] [schema] `ui_metric` (elastic#78827)
  [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772)
  [Discover] Unskip doc link functional test (elastic#78600)
  [ML] Functional tests - stabilize calendar edit tests (elastic#78950)
  [UX] Improve page responsive  (elastic#78759)
  [QA][Code Coverage] Team Assignment Docs Update (elastic#78890)
  [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra  (elastic#78209)
  [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855)
  ...
shahzad31 added a commit that referenced this pull request Oct 1, 2020
@shahzad31 @elasticmachine
[7.x] [UX] Improve page-load axis (#78392) (#79075)
7ce4b6a 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@sorenlouv sorenlouv removed the Team:APM All issues that need APM UI Team support label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzad31 @elasticmachine @kibanamachine @justinkambic @sorenlouv