Rename namespaces to initialNamespaces for create operations
#79682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jportner
added
v8.0.0
release_note:skip
This was referenced Oct 6, 2020
rudolf
reviewed
Oct 6, 2020
| @@ -44,16 +44,16 @@ export const registerCreateRoute = (router: IRouter) => { | |||
| }) | |||
| ) | |||
| ), | |||
| namespaces: schema.maybe(schema.arrayOf(schema.string(), { minSize: 1 })), | |||
| initialNamespaces: schema.maybe(schema.arrayOf(schema.string(), { minSize: 1 })), | |||
There was a problem hiding this comment.
If beats is sending namespaces in it's payload, won't it fail validation here?
There was a problem hiding this comment.
It would fail using the external create API route, but not using the legacy import API (which does not validate object fields)
|
Test failure looks unrelated, probably CI madness due to all the merges today, I'm going to merge upstream / retest to see if that fixes it |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
joshdover
approved these changes
Oct 6, 2020
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Oct 6, 2020
jportner
added a commit
that referenced
this pull request
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #76132 we added the ability to create multi-namespace saved objects in an initial set of consumer-defined namespaces (via "create" and "bulkCreate" APIs). However, retrieving objects via "get", "bulkGet", or "find" will also return each object's current namespace(s) in a
namespacesfield. If a consumer is attempting to create a new object based on that result, they will unintentionally attempt to set the new object's initial namespaces.To avoid this behavior, we'll rename these fields to
initialNamespacesfor create operations so they cannot be accidentally conflated with the results of read operations.