Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Reverts rules table tag filter to use AND operator #79920

Merged
merged 1 commit into from
Oct 8, 2020
Merged

[Security Solution][Detections] Reverts rules table tag filter to use AND operator #79920

merged 1 commit into from
Oct 8, 2020

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Oct 7, 2020 •
edited
Loading

Summary

Addresses #79913
Switches the tag filter operator on the All Rules table to use an OR operator instead of an AND.

Screen Shot 2020-10-07 at 2 44 52 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dplumlee dplumlee added release_note:fix Team:SIEM v8.0.0 v7.10.0 Feature:Detection Rules Anything related to Security Solution's Detection Rules labels Oct 7, 2020
@dplumlee dplumlee self-assigned this Oct 7, 2020
@dplumlee dplumlee linked an issue Oct 7, 2020 that may be closed by this pull request
[Security Solution][Detections] Update tags filtering on All Rules table to be and instead of or #79913
Closed
@dplumlee dplumlee removed a link to an issue Oct 7, 2020
[Security Solution][Detections] Update tags filtering on All Rules table to be and instead of or #79913
Closed
@dplumlee dplumlee marked this pull request as ready for review October 7, 2020 20:50
@dplumlee dplumlee requested review from a team as code owners October 7, 2020 20:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

spong
spong approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix @dplumlee! 🙂

cc @elastic/protections

@spong spong added the v7.11.0 label Oct 7, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
securitySolution 10.5MB 10.5MB +2.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dplumlee dplumlee merged commit ba6e1bf into elastic:master Oct 8, 2020
@dplumlee dplumlee deleted the revert-rule-tag-operator branch October 8, 2020 00:05
@dplumlee dplumlee mentioned this pull request Oct 8, 2020
Merged
dplumlee added a commit to dplumlee/kibana that referenced this pull request Oct 8, 2020
@dplumlee
[Security Solution][Detections] Reverts rules table tag filter to use…
a7d7442 
… AND operator (elastic#79920)
@dplumlee dplumlee mentioned this pull request Oct 8, 2020
Merged
dplumlee added a commit that referenced this pull request Oct 8, 2020
@dplumlee
[Security Solution][Detections] Reverts rules table tag filter to use…
3aed9f2 
… AND operator (#79920) (#79961)
dplumlee added a commit that referenced this pull request Oct 8, 2020
@dplumlee
[Security Solution][Detections] Reverts rules table tag filter to use…
eb37b68 
… AND operator (#79920) (#79960)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 8, 2020
@gmmorris
Merge branch 'master' into task-manager/health
2f12de5 
* master: (217 commits)
  Fix dashboard "snapshot share" is not sharing panel state in view mode (elastic#79837)
  fix can't edit a scripted field with special char (elastic#79842)
  [ML] clear selection action (elastic#79834)
  [TSVB] Show tooltip on external pointer events (elastic#77306)
  Fixes bug where the same index was being passed in (elastic#79949)
  Adds date time query and return fields for timestamps and overrides (elastic#79911)
  [Security Solution][Detections] Reverts rules table tag filter to use AND operator (elastic#79920)
  add the correct class to truncate the names (elastic#79921)
  [kbn/optimizer] report limits with ci metrics (elastic#78205)
  [release notes] extract "dev docs" comment too (elastic#79351)
  Revert "skips test failing promotion (elastic#79777)" (elastic#79904)
  share tslib across bundles (elastic#79915)
  remove entire suite as partial skips aren't doing the trick
  skip flaky suite (elastic#78689)
  Skip failing suite (elastic#79522)
  skip flaky suite (elastic#79910)
  [es/mappings] remove doc_values from text fields (elastic#79869)
  remove skipped snapshots
  skip flaky tests (elastic#79891)
  chore(NA): add missing branches into backportrc configuration file (elastic#79848)
  ...
@spong spong added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Oct 8, 2020
@spong
Copy link
Member

spong commented Oct 8, 2020

Note: Swapping labels to release_note:skip since this reverts back to the default behavior in 7.9, so there won't be a user facing change release-over-release.

@peluja1012 peluja1012 mentioned this pull request Oct 14, 2020
Closed
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@dplumlee dplumlee

Labels
Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dplumlee @elasticmachine @kibanamachine @spong @MindyRS