Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabify - support docs #80351

Merged
merged 6 commits into from
Oct 22, 2020
Merged

tabify - support docs #80351

merged 6 commits into from
Oct 22, 2020

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Oct 13, 2020

Summary

Adds support for raw document to tabify function which converts raw elastic search response to a table.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ppisljar ppisljar requested a review from a team as a code owner October 13, 2020 14:30
@ppisljar ppisljar added Feature:Search Querying infrastructure in Kibana Team:AppArch WIP Work in progress labels Oct 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a once-over but haven't done a deep review yet. Makes sense so far, though I think we should do some tests for tabify_docs.

src/plugins/data/common/search/tabify/index.ts Outdated Show resolved Hide resolved
@ppisljar ppisljar added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Oct 15, 2020
@ppisljar ppisljar removed the WIP Work in progress label Oct 19, 2020
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay got to comb through this more carefully today -- my main question is around how/if flattenHit functionally differs from the one in index patterns, and whether they could potentially be shared.

src/plugins/data/common/search/tabify/index.ts Outdated Show resolved Hide resolved
src/plugins/data/common/search/tabify/tabify_docs.ts Outdated Show resolved Hide resolved
src/plugins/data/common/search/tabify/tabify_docs.ts Outdated Show resolved Hide resolved
src/plugins/data/common/search/tabify/tabify_docs.ts Outdated Show resolved Hide resolved
src/plugins/data/common/search/tabify/tabify_docs.ts Outdated Show resolved Hide resolved
}
return flat;
})
.filter((hit) => hit);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The .map().filter() could probably be combined into a single reduce

src/plugins/data/common/search/tabify/tabify_docs.test.ts Outdated Show resolved Hide resolved
# Conflicts:
#	src/plugins/data/public/public.api.md
#	src/plugins/data/server/server.api.md
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
data 574 575 +1

distributable file count

id before after diff
default 48052 48053 +1
oss 28571 28572 +1

page load bundle size

id before after diff
data 1.1MB 1.1MB +4.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code updates LGTM!

@ppisljar ppisljar merged commit 62f34f2 into elastic:master Oct 22, 2020
ppisljar added a commit to ppisljar/kibana that referenced this pull request Oct 22, 2020
ppisljar added a commit that referenced this pull request Oct 22, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 22, 2020
* master: (63 commits)
  [KP] Fix Headers timeout issue (elastic#81140)
  [ML] Functional tests - stabilize typing with checks service method (elastic#81338)
  tabify - support docs (elastic#80351)
  [Security Solution][Detections] Look-back time logic fix (elastic#81383)
  [Workplace Search] Add top-level tests for Groups (elastic#81215)
  [Fleet] Fix agent action observable for long polling (elastic#81376)
  [Maps] fix feature tooltip remains open when zoom level change hides layer (elastic#81373)
  skip flaky suite (elastic#78689)
  chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies (elastic#81357)
  Ensure some data is returned (elastic#81375)
  Change dumb-init to tini (elastic#81126)
  [Reporting/Tech Debt] Convert PdfMaker class to TypeScript (elastic#81242)
  Use Storybook Controls instead of Knobs (elastic#80705)
  [junit] make sure that report paths are unique (elastic#81255)
  bump elastic/elasticsearch-js version to 7.10.0-rc1 (elastic#81288)
  run ssl tests on CI (elastic#81320)
  Fix alert defaults (elastic#81207)
  [ML] DF Analytics wizard: ensure user can set mml manually or select to use given estimate (elastic#81078)
  Add UI notifier to indicate secret fields and to remember / reenter values (elastic#80657)
  [Monitoring] Use async/await (elastic#81200)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants