Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load reporting #80492

Merged
merged 5 commits into from
Oct 16, 2020
Merged

Lazy load reporting #80492

merged 5 commits into from
Oct 16, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Oct 14, 2020

Summary

Closes #78242

  • Lazy-loads Reporting management app section.
  • Lazy-loads Dashboard sharing context menu panel React components.

@streamich streamich added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.11.0 v8.0.0 labels Oct 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
reporting 45 49 +4

async chunks size

id before after diff
reporting 0.0B 114.3KB +114.3KB

distributable file count

id before after diff
default 48492 48504 +12

page load bundle size

id before after diff
reporting 164.5KB 72.0KB -92.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I love the fact you went beyond just resolving the issue to lazy load the Management section, but also have lazy-loading for the Dashboard sharing context menu.

@streamich streamich merged commit fc5ad4d into elastic:master Oct 16, 2020
streamich added a commit that referenced this pull request Oct 16, 2020
* perf: ⚡️ load dynamically reporting management section

* refactor: 💡 remove JSX from main plugin entry file

* perf: ⚡️ lazy-load CSV sharing panel React component

* perf: ⚡️ lazy-load screen capture sharing panel React components

* feat: 🎸 show spinner while shring panels are loading
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 19, 2020
* master: (51 commits)
  [Discover] Unskip flaky test (elastic#80670)
  Fix security solution template label (elastic#80754)
  [Ingest]: ignore 404, check if there are transforms in results. (elastic#80721)
  Moving loader to logo in header, add a slight 250ms pause (elastic#78879)
  [Security Solution][Cases] Fix bug with case connectors (elastic#80642)
  Update known-plugins.asciidoc (elastic#75388)
  [Lens] Add median operation (elastic#79453)
  Fix navigateToApp logic when navigating to the current app. (elastic#80809)
  [Visualizations] Fix bad color mapping with multiple split series (elastic#80801)
  [ILM] Add esErrorHandler for the new es js client (elastic#80302)
  Fix codeowners (elastic#80826)
  skip flaky suite (elastic#79463)
  [Timelion] Remove kui usage (elastic#80287)
  [Ingest Manager] add skipIfNoDockerRegistry to package_install_complete test (elastic#80779)
  [Alerting UI] Disable "Save" button for Alerts with broken Connectors (elastic#80579)
  Allow the default space to be accessed via `/s/default` (elastic#77109)
  Add script to identify plugin dependencies for TS project references migration (elastic#80463)
  [Search] Client side session service (elastic#76889)
  feat: 🎸 add separator for different context menu groups (elastic#80498)
  Lazy load reporting (elastic#80492)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reporting/Enhancement] Lazy load Reporting Management App
4 participants