[ML] Functional tests - fix and re-enable validation API tests #80617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
|
Checking test stability in a flaky test runner job ... no failure in 50 runs ✔️ |
walterra
approved these changes
Oct 15, 2020
Comment on lines
255
to
257
| modelPlotCardinality: 'WILL BE VALIDATED SEPARATELY BELOW', | ||
| text: 'WILL BE VALIDATED SEPARATELY BELOW', | ||
| status: 'WILL BE VALIDATED SEPARATELY BELOW', |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Oct 15, 2020
…ic#80617) This PR fixes and re-enables the recently disabled job validation API tests that validate cardinalities.
pheyos
added a commit
that referenced
this pull request
Oct 15, 2020
… (#80646) This PR fixes and re-enables the recently disabled job validation API tests that validate cardinalities.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 15, 2020
* master: (102 commits) [Resolver] Fix flaky test (elastic#80576) Update Security Solution Bug Report Template (elastic#80668) [Observability] Kibana home page Observability link pointing to `/landing` (elastic#80636) [APM] Update User Experience app callout code to reflect new name (elastic#80641) [APM] Add missing ML privileges (elastic#80553) [DOCS] Adds intro line to the ML plugin readme file (elastic#80631) [ML] Functional tests - fix and re-enable validation API tests (elastic#80617) remove non-existing dependency from uptime plugin (elastic#80623) [ML] Fix job selection flyout overflow (elastic#80621) Move dashboard code in codeowner files to canvas team (elastic#80345) [Security Solution][Detections] Update signals template if outdated and rollover indices (elastic#80019) Sort service list by TPM if health is not shown (elastic#80447) Add in cluster version for sec telemetry sender. (elastic#80545) [Usage Collection] Usage collection add saved objects client to collector fetch context (elastic#80554) Change tag from experimental to beta (elastic#80443) [Metrics UI] Inventory view cleanup (elastic#79881) [Security Solutions][Detection Engine] Critical bug where value lists were not operational (elastic#80368) [Security Solution] Fix networkTopNFlow search strategy response (elastic#80362) [build] Retry docker pull (elastic#80432) add template for Security Solution bugs (elastic#80574) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes and re-enables the recently disabled job validation API tests that validate cardinalities.
Details
According to the docs, the ES
cardinalityagg isSo we shouldn't validate exact values during tests and we just were lucky in the past that the tests delivered consistent results.
This PR introduces special handling for the
cardinality_model_plot_highentry of the validation response body to not check for exact numbers.Closes #80418